Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce "14" to "10" where it corresponds to the days of the risk calculation #2670

Closed
DerVogel2020 opened this issue Apr 4, 2022 · 12 comments
Labels
bug Something isn't working faq

Comments

@DerVogel2020
Copy link
Contributor

Where to find the issue

e.g. https://www.coronawarn.app/de/faq/results/#new_device :
Falls Sie innerhalb der 14 Tage auf COVID-19 getestet wurden, tragen Sie den PCR-Test-QR-Code auf Ihrem neuen Gerät ein. Ist das Testergebnis positiv, sollten Sie das Testergebnis auf beiden Geräten teilen. Für das Teilen eines Testergebnisses auf mehreren Geräten beachten Sie bitte den FAQ Eintrag Wie teile ich ein positives Testergebnis auf mehreren Geräten?.

Nach 14 Tagen enthält Ihr altes Gerät keine relevanten Einträge für die Risiko-Ermittlung mehr. Sie brauchen den Risikostatus auf diesem Gerät dann nicht weiter zu beachten und können die Corona-Warn-App dort entfernen.

Describe the issue

Only 10 days are relevant now.

Suggested change

Change everywhere "14 days" to "10 days" (of course in both languages).

@DerVogel2020 DerVogel2020 added the bug Something isn't working label Apr 4, 2022
@MikeMcC399
Copy link
Contributor

@DerVogel2020

Thanks for bringing this up!

"Damit Sie trotzdem über mögliche Risiko-Begegnungen informiert werden, empfehlen wir Ihnen, den Risikostatus auf dem alten Gerät noch mindestens 14 Tage (10 Tage ab Version 2.20) zu beobachten, nachdem Sie die Corona-Warn-App auf dem neuen Gerät installiert haben."

So I suggest that instead of changing 14 days to 10 days, it needs to list both. To simplify the text, the first mention defines the version differences and thereafter write 14 or 10 days (EN) 14 bzw. 10 Tage (DE) without mentioning the version.

@amouzayanni
Copy link
Contributor

@MikeMcC399

Hello! I'm working with @ahodzic2 and I'd like to resolve this issue if you'd like it done.

@MikeMcC399
Copy link
Contributor

@amouzayanni

@DerVogel2020 has contributed in the past, so might also want to provide a PR. Other than that I suggest waiting for feedback from the Open Source Team. I'm not the one to decide, since I am a community contributor with no official capacity.

@DerVogel2020
Copy link
Contributor Author

@amouzayanni From my point of view, it seems difficult to determine all relevant code lines. So feel free to provide a PR.

@dsarkar dsarkar added the faq label Apr 4, 2022
@MikeMcC399
Copy link
Contributor

There is a slight twist to this story if the device is being used internationally. Google stores 14 days, CWA from 2.20 onwards only uses the most recent 10 days of Random IDs stored by Google. I assume that the same is true for iOS.

If a user wishes to use another compatible COVID-19 app, it may be that the app from another country uses more than 10 days, so it could be that the old device needs to be kept for 14 days. This is an edge case, but be careful about the accuracy of any changes made to the article.

@amouzayanni
Copy link
Contributor

Will do! I'll get that pull request ready ASAP.

@amouzayanni
Copy link
Contributor

After reviewing the German FAQ, I no longer feel comfortable making changes to it since I fear the language barrier would prevent me from being accurate. I've finished the English FAQ and I'm ready to make the pull request. Will someone else be able to complete the German FAQ?

@Ein-Tim
Copy link
Contributor

Ein-Tim commented Apr 5, 2022

@amouzayanni

For sure.

Will you invite me to access your repo so that I can push the changes there?

You can also get in touch with me via Slack, as @ahodzic2 did.

@amouzayanni
Copy link
Contributor

@Ein-Tim

Just sent the invitation. Thanks for the help! I'd be happy to get in touch, how should I do so?

@Ein-Tim
Copy link
Contributor

Ein-Tim commented Apr 5, 2022

@MikeMcC399
Copy link
Contributor

MikeMcC399 commented Apr 6, 2022

Regarding my comment about considering the case of changing the app during the 14 or 10 days, I went through two scenarios:

  • a person goes on vacation to another EU country
  • a person moves permanently to another EU country

where the other EU country has their own app and the move happens during this period. I think in both cases that it would be quite unlikely that the user would install a different app on the old phone during these two weeks. So I would ignore this case.

Sorry for making this more complicated than it need have been. I was just trying to make sure we didn't give users incorrect information.

I already made a short comment about this in PR #2691.

@ahodzic2
Copy link
Contributor

ahodzic2 commented Apr 8, 2022

I believe with the PR merged this issue can be closed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working faq
Projects
None yet
Development

No branches or pull requests

6 participants