diff --git a/CHANGELOG.md b/CHANGELOG.md index 4c6b937cdb..f1e10fa1f7 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -3,6 +3,7 @@ ## master / unreleased * [FEATURE] Querier/Ruler: Add `query_partial_data` and `rules_partial_data` limits to allow queries/rules to be evaluated with data from a single zone, if other zones are not available. #6526 +* [ENHANCEMENT] StoreGateway: Emit more histogram buckets on the `cortex_querier_storegateway_refetches_per_query` metric. #6570 * [ENHANCEMENT] Querier: Apply bytes limiter to LabelNames and LabelValuesForLabelNames. #6568 * [ENHANCEMENT] Query Frontend: Add a `too_many_tenants` reason label value to `cortex_rejected_queries_total` metric to track the rejected query count due to the # of tenant limits. #6569 * [BUGFIX] Ingester: Avoid error or early throttling when READONLY ingesters are present in the ring #6517 diff --git a/pkg/querier/blocks_store_queryable.go b/pkg/querier/blocks_store_queryable.go index a6fcb602a9..1f1866826b 100644 --- a/pkg/querier/blocks_store_queryable.go +++ b/pkg/querier/blocks_store_queryable.go @@ -123,7 +123,7 @@ func newBlocksStoreQueryableMetrics(reg prometheus.Registerer) *blocksStoreQuery Namespace: "cortex", Name: "querier_storegateway_refetches_per_query", Help: "Number of re-fetches attempted while querying store-gateway instances due to missing blocks.", - Buckets: []float64{0, 1, 2}, + Buckets: []float64{0, 1, 2, 4, 8}, }), } } diff --git a/pkg/querier/blocks_store_queryable_test.go b/pkg/querier/blocks_store_queryable_test.go index 390f27107a..89eeb76332 100644 --- a/pkg/querier/blocks_store_queryable_test.go +++ b/pkg/querier/blocks_store_queryable_test.go @@ -614,6 +614,8 @@ func TestBlocksStoreQuerier_Select(t *testing.T) { cortex_querier_storegateway_refetches_per_query_bucket{le="0"} 1 cortex_querier_storegateway_refetches_per_query_bucket{le="1"} 1 cortex_querier_storegateway_refetches_per_query_bucket{le="2"} 1 + cortex_querier_storegateway_refetches_per_query_bucket{le="4"} 1 + cortex_querier_storegateway_refetches_per_query_bucket{le="8"} 1 cortex_querier_storegateway_refetches_per_query_bucket{le="+Inf"} 1 cortex_querier_storegateway_refetches_per_query_sum 0 cortex_querier_storegateway_refetches_per_query_count 1 @@ -913,6 +915,8 @@ func TestBlocksStoreQuerier_Select(t *testing.T) { cortex_querier_storegateway_refetches_per_query_bucket{le="0"} 0 cortex_querier_storegateway_refetches_per_query_bucket{le="1"} 0 cortex_querier_storegateway_refetches_per_query_bucket{le="2"} 1 + cortex_querier_storegateway_refetches_per_query_bucket{le="4"} 1 + cortex_querier_storegateway_refetches_per_query_bucket{le="8"} 1 cortex_querier_storegateway_refetches_per_query_bucket{le="+Inf"} 1 cortex_querier_storegateway_refetches_per_query_sum 2 cortex_querier_storegateway_refetches_per_query_count 1 @@ -1850,6 +1854,8 @@ func TestBlocksStoreQuerier_Labels(t *testing.T) { cortex_querier_storegateway_refetches_per_query_bucket{le="0"} 1 cortex_querier_storegateway_refetches_per_query_bucket{le="1"} 1 cortex_querier_storegateway_refetches_per_query_bucket{le="2"} 1 + cortex_querier_storegateway_refetches_per_query_bucket{le="4"} 1 + cortex_querier_storegateway_refetches_per_query_bucket{le="8"} 1 cortex_querier_storegateway_refetches_per_query_bucket{le="+Inf"} 1 cortex_querier_storegateway_refetches_per_query_sum 0 cortex_querier_storegateway_refetches_per_query_count 1 @@ -2078,6 +2084,8 @@ func TestBlocksStoreQuerier_Labels(t *testing.T) { cortex_querier_storegateway_refetches_per_query_bucket{le="0"} 0 cortex_querier_storegateway_refetches_per_query_bucket{le="1"} 0 cortex_querier_storegateway_refetches_per_query_bucket{le="2"} 1 + cortex_querier_storegateway_refetches_per_query_bucket{le="4"} 1 + cortex_querier_storegateway_refetches_per_query_bucket{le="8"} 1 cortex_querier_storegateway_refetches_per_query_bucket{le="+Inf"} 1 cortex_querier_storegateway_refetches_per_query_sum 2 cortex_querier_storegateway_refetches_per_query_count 1