Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Application CRD integration #76

Open
coryodaniel opened this issue Oct 30, 2019 · 1 comment
Open

Application CRD integration #76

coryodaniel opened this issue Oct 30, 2019 · 1 comment

Comments

@coryodaniel
Copy link
Owner

App Sig

For controllers that are creating multiple resources on behalf of a CRD.

Not exactly sure of the best way to integrate this, and not positive that all operators would benefit from it. So it may be best to implement as a module that could be used from a lifecycle function or possible as an additional library that can be included if needed.

I was thinking of implementing it as a struct that mimics the Application CRD's OpenAPI spec, but would accept a set of resource maps as well.

app = %Application{
  name: "wordpress-01",
  version: 3,
  components: [],
  assembly_phase: "Pending",
  descriptor: %{
    # version: 
    # description:
    # icons:
    # type:
    # maintainers:
    # owners:
    # keywords:
    # links:
  }
}

deployment = %{
  kind: "Deployment",
  # ...
}

service = %{
  kind: "Service",
  # ...
}

app
|> Application.add_component(deployment)
|> Application.add_component(service)
|> Application.apply

Application.apply/1 would apply each component resource w/ proper labels to integrate w/ the Application CRD and finally create the Application resource

@coryodaniel coryodaniel added this to the 0.5 release milestone Feb 17, 2020
@coryodaniel coryodaniel modified the milestones: 0.5 release, 1.0 release Jun 2, 2020
@mruoss
Copy link
Collaborator

mruoss commented Oct 2, 2022

I'd like to close this as won't do. I don't see value in it. Taking it out of 1.0 milestone for now.

@mruoss mruoss removed this from the 1.0 release milestone Oct 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants