Skip to content
This repository has been archived by the owner on Oct 15, 2020. It is now read-only.

Evidence not included in begin block #80

Open
antho1404 opened this issue Jun 3, 2020 · 1 comment
Open

Evidence not included in begin block #80

antho1404 opened this issue Jun 3, 2020 · 1 comment

Comments

@antho1404
Copy link

Should Evidence module be included in the SetOrderBeginBlockers?

The evidence module is doing some check on the begin block but SetOrderBeginBlockers reset the list of beginBlocks to apply and the begin block of evidence will never be called.

Am I missing something?
Also this might be the case for other modules as well

app.mm.SetOrderBeginBlockers(upgrade.ModuleName, mint.ModuleName, distr.ModuleName, slashing.ModuleName)

@tac0turtle
Copy link
Member

The other module are registered through the appmodule interface. This will be below with app.SetBeginBlocker(app.BeginBlocker) This is how its done within Gaia, but the sdk simapp is regestering evidence. I will have to double check the reasoning behind this.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants