Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increase the maximum number of key-value pairs that can be proven at once #250

Closed
srdtrk opened this issue Jan 30, 2025 · 0 comments · Fixed by #251
Closed

Increase the maximum number of key-value pairs that can be proven at once #250

srdtrk opened this issue Jan 30, 2025 · 0 comments · Fixed by #251
Labels
enhancement Improvements sp1 Related to sp1 programs or contracts.

Comments

@srdtrk
Copy link
Member

srdtrk commented Jan 30, 2025

we assume that the number of kv-pairs can be represented by a u8 in the sp1-program. Increase this limitation to u16 or set a hardcoded limit manually.

solidity-ibc-eureka/packages/sp1-ics07-tendermint-prover/src/prover.rs

Line 139 in ec5227e

let len = u8::try_from(kv_proofs.len()).expect("too many key-value pairs");

@srdtrk srdtrk added enhancement Improvements sp1 Related to sp1 programs or contracts. labels Jan 30, 2025
@mmsqe mmsqe mentioned this issue Feb 2, 2025
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement Improvements sp1 Related to sp1 programs or contracts.
Projects
None yet
Milestone
No milestone
1 participant
@srdtrk