Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate and refactor ICS20 sendPacket flow #219

Closed
3 of 7 tasks
srdtrk opened this issue Jan 16, 2025 · 1 comment · Fixed by #254
Closed
3 of 7 tasks

Validate and refactor ICS20 sendPacket flow #219

srdtrk opened this issue Jan 16, 2025 · 1 comment · Fixed by #254
Assignees
Labels
20-transfer Issues related to the ICS20 application security This issue impacts security assumptions solidity Issues related to the solidity contracts

Comments

@srdtrk
Copy link
Member

srdtrk commented Jan 16, 2025

Summary

While implementing 3-chain workflows, several bugs were discovered in ICS20 sendPacket flow (both in solidity-ibc-eureka and ibc-go). The goal of this issue is to validate/refactor the design of sendPacket flow in solidity-ibc-eureka and implement new tests for this flow.

Problem Definition

While implementing #215, I ran into the following bugs:

Both of which could be the signs of a larger design flaw. At this moment, it is not clear whether or not cosmos/ibc-go#7848 affects solidity-ibc-eureka.

Next Steps


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged/assigned
  • Estimate provided
@srdtrk srdtrk added 20-transfer Issues related to the ICS20 application needs discussion This issue needs more discussion before its implementation solidity Issues related to the solidity contracts labels Jan 16, 2025
@srdtrk srdtrk added the security This issue impacts security assumptions label Jan 17, 2025
@srdtrk
Copy link
Member Author

srdtrk commented Jan 20, 2025

We've decided to refactor the sendPacket flow not to directly use payload and instead use MsgTransfer

@srdtrk srdtrk removed the needs discussion This issue needs more discussion before its implementation label Jan 20, 2025
@srdtrk srdtrk mentioned this issue Feb 4, 2025
6 tasks
@srdtrk srdtrk moved this from Backlog to In progress in IBC-GO Eureka Feb 4, 2025
@gjermundgaraba gjermundgaraba moved this from In progress to In review in IBC-GO Eureka Feb 6, 2025
@github-project-automation github-project-automation bot moved this from In review to Done in IBC-GO Eureka Feb 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
20-transfer Issues related to the ICS20 application security This issue impacts security assumptions solidity Issues related to the solidity contracts
Projects
Status: Done
1 participant