Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make ICS20Transfer pausable #231

Closed
2 of 4 tasks
srdtrk opened this issue Jan 22, 2025 · 1 comment · Fixed by #257
Closed
2 of 4 tasks

Make ICS20Transfer pausable #231

srdtrk opened this issue Jan 22, 2025 · 1 comment · Fixed by #257
Labels
security This issue impacts security assumptions solidity Issues related to the solidity contracts type: feature Feature request

Comments

@srdtrk
Copy link
Member

srdtrk commented Jan 22, 2025

Summary

Allow a security council to pause ICS26Router. This pause should be reversible by the governance of the counterparty chain.

Use cases

  • Freezing the contract in case of a security vulnerability without being subject to a timelock that'd otherwise be enforced on the security council.
  • The freeze should be reversible by the governance of the counterparty chain which is also not subject to timelocks.

Proposal

Use openzepellin's Pausable contract

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged/assigned
  • Estimate provided
@srdtrk srdtrk added solidity Issues related to the solidity contracts type: feature Feature request labels Jan 22, 2025
@srdtrk srdtrk added the security This issue impacts security assumptions label Jan 22, 2025
@srdtrk
Copy link
Member Author

srdtrk commented Jan 28, 2025 •
edited
Loading

I think this issue needs more discussion since it might make more sense to have only ICS20Transfer be pausable. Since we want to use ICA admin to unpause which would rely on ICS26Router to function

@srdtrk srdtrk added the needs discussion This issue needs more discussion before its implementation label Jan 28, 2025
@srdtrk srdtrk changed the title Make ICS26Router pausable Make ICS20Transfer pausable Feb 5, 2025
@srdtrk srdtrk removed the needs discussion This issue needs more discussion before its implementation label Feb 5, 2025
@srdtrk srdtrk moved this from Backlog to In progress in IBC-GO Eureka Feb 5, 2025
@srdtrk srdtrk mentioned this issue Feb 5, 2025
Merged
6 tasks
@srdtrk srdtrk moved this from In progress to In review in IBC-GO Eureka Feb 5, 2025
@github-project-automation github-project-automation bot moved this from In review to Done in IBC-GO Eureka Feb 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
security This issue impacts security assumptions solidity Issues related to the solidity contracts type: feature Feature request
Projects
IBC-GO Eureka
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: added pausability to ics20 cosmos/solidity-ibc-eureka
1 participant
@srdtrk