Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement Permit2 for ICS20Transfer #162

Closed
gjermundgaraba opened this issue Dec 9, 2024 · 0 comments · Fixed by #269
Closed

Implement Permit2 for ICS20Transfer #162

gjermundgaraba opened this issue Dec 9, 2024 · 0 comments · Fixed by #269
Assignees
@gjermundgaraba
Labels
20-transfer Issues related to the ICS20 application

Comments

@gjermundgaraba
Copy link
Contributor

Permit-based ERC20 transfer have better UX and potentially better overall gas usage than only using allowance. We should support this.

https://github.com/Uniswap/permit2

TODO: Add more information on implementation.
@gjermundgaraba gjermundgaraba added the 20-transfer Issues related to the ICS20 application label Dec 9, 2024
@github-project-automation github-project-automation bot moved this to Backlog in IBC-GO Eureka Dec 9, 2024
@gjermundgaraba gjermundgaraba self-assigned this Jan 5, 2025
@gjermundgaraba gjermundgaraba removed their assignment Feb 6, 2025
@womensrights womensrights mentioned this issue Feb 6, 2025
Closed
@gjermundgaraba gjermundgaraba moved this from Backlog to In progress in IBC-GO Eureka Feb 7, 2025
@gjermundgaraba gjermundgaraba mentioned this issue Feb 10, 2025
Open
@gjermundgaraba gjermundgaraba linked a pull request Feb 10, 2025 that will close this issue
feat: permit2 support in ICS20 #269
Merged
6 tasks
@gjermundgaraba gjermundgaraba mentioned this issue Feb 10, 2025
Merged
6 tasks
@github-project-automation github-project-automation bot moved this from In progress to Done in IBC-GO Eureka Feb 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gjermundgaraba gjermundgaraba

Labels
20-transfer Issues related to the ICS20 application
Projects
IBC-GO Eureka
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: permit2 support in ICS20 cosmos/solidity-ibc-eureka
1 participant
@gjermundgaraba