Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No pythemis_uninstall target in Makefile #948

Open
1 of 2 tasks
sashimanu-san opened this issue Sep 22, 2022 · 1 comment
Open
1 of 2 tasks

No pythemis_uninstall target in Makefile #948

sashimanu-san opened this issue Sep 22, 2022 · 1 comment
Labels
enhancement infrastructure Automated building and packaging W-PyThemis 🐍 Wrapper: PyThemis, Python API

Comments

@sashimanu-san
Copy link

Describe the bug
An uninstall makefile target is missing for python bindings.

To Reproduce
Steps to reproduce the behavior:

  1. Use 'make pythemis_install'
  2. Run 'make pythemis_uninstall'
  3. See the following error:
make: *** No rule to make target 'pythemis_uninstall'.  Stop.

Expected behavior
Should be able to uninstall pythemis as it is the case with other language bindings (make phpthemis_uninstall and rbthemis_uninstall).

Environment (please complete the following information):

  • OS: Debian 11.4
  • Hardware: 64-bit
  • Themis version: 0.14.0-23-g3a36aa4a
  • Installation way:
    • via package manager
    • built from source
@vixentael vixentael added infrastructure Automated building and packaging enhancement labels Sep 22, 2022
@vixentael
Copy link
Contributor

yeah, makes sense, might add to

https://github.com/cossacklabs/themis/blob/master/Makefile#L606

@vixentael vixentael added the W-PyThemis 🐍 Wrapper: PyThemis, Python API label Sep 22, 2022
sashimanu-san added a commit to sashimanu-san/themis that referenced this issue Sep 23, 2022
@sashimanu-san
Add pythemis_uninstall target to Makefile. Fixes cossacklabs#948
6e151ae
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement infrastructure Automated building and packaging W-PyThemis 🐍 Wrapper: PyThemis, Python API
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sashimanu-san @vixentael