Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Query parameter parsing of Courier records ignores custom StringKeyFormat #199

Open
yifan-coursera opened this issue Jun 28, 2017 · 0 comments

Comments

@yifan-coursera
Copy link
Contributor

If you use Courier records as query parameters, Naptime uses InlineStringCodec / StringKeyCodec to parse that parameter instead of whatever StringKeyFormat you specify.

We call into CourierQueryParsers here which calls into those codecs here.

If the Courier record query parameter contains any typedef fields that have a custom StringKeyFormat defined, that StringKeyFormat is ignored. Suppose, if I have a Courier model containing a UUID field and a base64 encoded field. The base64 encoded field uses a custom StringKeyFormat. If the record is in the ID position for a GET, the base64 decoding happens correctly. If the record is in the query param position in a finder, the decoding does not happen. Also, the decoding works properly if a Scala case class is used instead of a Courier record.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant