Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v1.50.0] Safe: Approve and Review Limit/TWAP button is not changed to Review when an order is executed #3428

Closed
elena-zh opened this issue Nov 23, 2023 · 2 comments
Closed

[v1.50.0] Safe: Approve and Review Limit/TWAP button is not changed to Review when an order is executed #3428

elena-zh opened this issue Nov 23, 2023 · 2 comments
Assignees
@shoom3301
Labels
Bug Something isn't working Low Severity indicator for defects. It won't cause any major break-down of the system

Comments

@elena-zh
Copy link
Contributor

elena-zh commented Nov 23, 2023 •
edited
Loading

Related to #3417

  1. Open the app inside the Safe
  2. Open Limit orders/TWAP page
  3. Select a not approved token to trade
  4. Place an order with a bundled approval transaction
  5. Wait till the TX is signed and executed

AR: 'Approve and limit order' (or 'Approve and TWAP') button remains to be displayed
image

ER: buttons should be changed to 'Review Limit order' ('Review TWAP') when a token is approved
@elena-zh elena-zh added Bug Something isn't working Low Severity indicator for defects. It won't cause any major break-down of the system labels Nov 23, 2023
@shoom3301 shoom3301 self-assigned this Dec 5, 2023
@shoom3301 shoom3301 mentioned this issue Dec 5, 2023
Merged
2 tasks
@shoom3301
Copy link
Collaborator

Thank you!
Fixed in #3417

@elena-zh
Copy link
Contributor Author

elena-zh commented Dec 5, 2023

Changes LGTM!

@elena-zh elena-zh closed this as completed Dec 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shoom3301 shoom3301

Labels
Bug Something isn't working Low Severity indicator for defects. It won't cause any major break-down of the system
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@shoom3301 @elena-zh