feat(widget): add maxHeight parameter for the widget #5127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
shoom3301
commented
Nov 25, 2024
| @@ -1,6 +1,6 @@ | |||
| { | |||
| "name": "@cowprotocol/widget-lib", | |||
| "version": "0.17.0", | |||
| "version": "0.18.0", | |||
There was a problem hiding this comment.
I would like to release a new version just after merging the PR
|
Report too large to display inline |
elena-zh
approved these changes
Nov 25, 2024
There was a problem hiding this comment.
Hey @shoom3301 , great, thank you!
Please, don't forget to update dev docs with this change :)
And I hope that users will figure out their the best widget height to specify
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
https://www.titanxhub.com/swap - if you click "connect wallet" in the widget here, you will see that the modal is displayed not correctly.
It happens because we always take
document.body.offsetHeightas a max height for the widget.In order to handle that, I've added a new parameter -
maxHeight.To Test
{"maxHeight": 200}in "Raw JSON params" field