Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Orders Table Status Box Layout #5406

Merged
merged 1 commit into from
Feb 6, 2025
Merged

Fix Orders Table Status Box Layout #5406

merged 1 commit into from
Feb 6, 2025

Conversation

fairlighteth
Copy link
Contributor

@fairlighteth fairlighteth commented Feb 6, 2025

Fix Orders Table Status Box Layout

Addresses #5403

Description

This PR addresses layout issues in the orders table, specifically focusing on the status box component and overall column widths. The changes ensure better visual consistency and prevent text wrapping issues in the status indicators.

Changes

  1. Status Box Improvements

    • Added white-space: nowrap to prevent status text from breaking into multiple lines
    • This ensures status indicators remain on a single line for better readability. Specifically for the 'partially filled' status.
  2. Table Column Width Adjustments

    • Fine-tuned column widths in both history tab and default layouts
    • Standardized status column width to minmax(106px,112px) (previously minmax(80px, 0.8fr))
    • Adjusted adjacent columns for better overall table balance

Files Changed

  • apps/cowswap-frontend/src/modules/ordersTable/pure/OrderStatusBox/index.tsx
  • apps/cowswap-frontend/src/modules/ordersTable/pure/OrdersTableContainer/styled.tsx

Type of Change

  • Bug fix (non-breaking change fixing layout issues)
  • New feature (non-breaking change adding functionality)
  • Breaking change (fix or feature causing existing functionality to change)

Testing Steps

  1. Open the orders table
  2. Verify status indicators don't wrap to multiple lines
  3. Check both history tab and default layouts
  4. Ensure column widths are consistent and properly aligned

Screenshots

Screenshot 2025-02-06 at 11 31 32 Screenshot 2025-02-06 at 11 31 22 Screenshot 2025-02-06 at 11 31 11 Screenshot 2025-02-06 at 11 31 02 Screenshot 2025-02-06 at 11 30 55

Copy link

vercel bot commented Feb 6, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
cosmos ✅ Ready (Inspect) Visit Preview Feb 6, 2025 11:45am
cowfi ✅ Ready (Inspect) Visit Preview Feb 6, 2025 11:45am
explorer-dev ✅ Ready (Inspect) Visit Preview Feb 6, 2025 11:45am
sdk-tools ✅ Ready (Inspect) Visit Preview Feb 6, 2025 11:45am
swap-dev ✅ Ready (Inspect) Visit Preview Feb 6, 2025 11:45am
widget-configurator ✅ Ready (Inspect) Visit Preview Feb 6, 2025 11:45am

Copy link
Contributor

@elena-zh elena-zh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @fairlighteth ,
looks good to me!

@alfetopito alfetopito merged commit f8f6b87 into develop Feb 6, 2025
12 of 13 checks passed
@alfetopito alfetopito deleted the statusbox-fix branch February 6, 2025 16:59
@github-actions github-actions bot locked and limited conversation to collaborators Feb 6, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants