Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

integration with es6 files #11

Open
Luxor opened this issue Mar 9, 2016 · 5 comments
Open

integration with es6 files #11

Luxor opened this issue Mar 9, 2016 · 5 comments

Comments

@Luxor
Copy link

Luxor commented Mar 9, 2016

Hi,

We are using grails-babel plugin (https://grails.org/plugin/babel-asset-pipeline). Which is using es6 file extension by default (we have mix of js and es6 files)

Is there is a way to enable ng-annotate for es6 and js files.

Thanks, Anton

@musketyr
Copy link

@craigburke I'm not quite sure the trick with loadAfter works. didn't seem to work with coffee script either.

musketyr added a commit to musketyr/angular-annotate-asset-pipeline that referenced this issue Apr 16, 2016
this doesn't seem to work but maybe my local hack didn't go throught
@craigburke
Copy link
Owner

craigburke commented Apr 16, 2016

@musketyr I don't think it will unfortunately. I have some ideas though.

@musketyr
Copy link

creating file META-INF/asset-pipeline/processor.specs with following content works like a charm

com.craigburke.angular.AnnotateProcessor=asset.pipeline.JsAssetFile,asset.pipeline.babel.Es6AssetFile,asset.pipeline.babel.JsxAssetFile,asset.pipeline.coffee.CoffeeAssetFile

the question is if you can do same in your descriptor (i.e. is the asset pipeline tolerant to missing classes in the definition?)

@craigburke
Copy link
Owner

@musketyr that's a really good idea. I think it should work. See any issues with doing this @davydotcom?

@musketyr
Copy link

it looks it's working: MetadataConsulting/ModelCataloguePlugin@5240125

I had to redeclare the processor in my own plugin. also I think this should come with having both plugins in loadAfter config.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants