-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug] CSS Link Tag Does Not Follow Vocabulary Documentation #220
Comments
Hello, I am an Outreachy applicant, I would like to work on this. |
hi @bhekidaweti , I hope you're doing okay. You can indicate your interest in an issue by opening a pull request with your own solution for the issue. However, any issue that you open a PR for must have the ready for work label. I hope this helps clarify things for you and I hope you have a good time contributing to this project. |
Please see Contribution Guidelines — Creative Commons Open Source for how we manage issues and pull requests (PRs). We generally don't assign issues prior to resolution. Instead of asking for issues to be assigned, do the work and submit a PR. Even if multiple people submit PRs for the same issue, multiple ideas and implementations strengthen the final product. For work program applicants, each can all list their own PRs on their application. It is the quality of work that is important, not whether it is merged. |
Thanks, I fully understand now. |
@babyteega please add a comment to this issue so I can assign it to you |
Description
The
<link>
tag for the CSS file is missing the media attribute, which is required for proper HTML semantics.And this does not follow the vocabulary docs. In the vocabulary docs, link tag for stylesheets must have the
media="all"
.Reproduction
base.html
in scholarship folder<link>
tag for the CSS file does not include a media attribute:legaldb/legal_db/templates/legal_db/base.html
Line 12 in 83e0303
Expectation
The link tag for stylesheet should have the
media="all"
as stated in Vocabulary documentation.Additional context
Resolution
The text was updated successfully, but these errors were encountered: