Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] consistently use single quotes in CSS files #326

Open
1 task done
shivam8112005 opened this issue Nov 22, 2024 · 2 comments
Open
1 task done

[Feature] consistently use single quotes in CSS files #326

shivam8112005 opened this issue Nov 22, 2024 · 2 comments
Labels
💻 aspect: code Concerns the software code in the repository ✨ goal: improvement Improvement to an existing feature 🟩 priority: low Low priority and doesn't need to be rushed 🏷 status: label work required Needs proper labelling before it can be worked on 💬 talk: discussion Open for discussions and feedback

Comments

@shivam8112005
Copy link
Contributor

Problem

Inconsistent use of quotation styles in normalize.css file (single vs. double quotes) can reduce code readability, introduce unnecessary diffs in version control, and complicate style enforcement across teams. This inconsistency also makes it harder to apply automated linting rules.
with reference to #322

Description

Standardizing the use of single quotes in the normalize.css file ensures consistency across the codebase. This improvement enhances readability, simplifies collaboration, and allows for seamless integration with automated linting tools.

Alternatives

  1. Stick with double quotes: While valid, this approach may not align with established preferences and would require similar enforcement.
  2. Allow both styles: This would avoid standardization but negates the benefits of readability, linting, and reduced version control diffs.

Additional context

Using single quotes aligns normalize.css with broader project conventions if single quotes are preferred across the CSS codebase. It also integrates well with stylelint rules, such as string-quotes: 'single', to enforce consistency.

Implementation

  • I would be interested in implementing this feature.
@shivam8112005 shivam8112005 added ✨ goal: improvement Improvement to an existing feature 💻 aspect: code Concerns the software code in the repository 🚦 status: awaiting triage Has not been triaged & therefore, not ready for work 🟩 priority: low Low priority and doesn't need to be rushed labels Nov 22, 2024
@possumbilities
Copy link
Contributor

@shivam8112005 As this is an external dependency and is "vendored", I'm not sure it would be prudent to reformat the file to match this project's formatting preferences; since that may make it harder to track any upstream changes over time.

I'm going to leave this as a Discussion for now in case others have counter-arguments; but for the time being I think it best we not try to reformat vendor files.

@possumbilities possumbilities added 💬 talk: discussion Open for discussions and feedback and removed 🚦 status: awaiting triage Has not been triaged & therefore, not ready for work labels Nov 25, 2024
@possumbilities possumbilities moved this from Triage to Backlog in possumbilities Nov 25, 2024
@shivam8112005
Copy link
Contributor Author

@possumbilities ohk got it

@cc-open-source-bot cc-open-source-bot added the 🏷 status: label work required Needs proper labelling before it can be worked on label Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💻 aspect: code Concerns the software code in the repository ✨ goal: improvement Improvement to an existing feature 🟩 priority: low Low priority and doesn't need to be rushed 🏷 status: label work required Needs proper labelling before it can be worked on 💬 talk: discussion Open for discussions and feedback
Projects
Status: Backlog
Development

No branches or pull requests

3 participants