[Feature] Remove invalid handling of 'data' output as if it was a valid File reference

[fmigneault]

Inside weaver.processes.wps_package.WpsPackage.make_location_outputs, some handling of non-File type resulting from CWL execution is still being done. (backward compatibility)

weaver/weaver/processes/wps_package.py

Lines 2240 to 2251 in de7905c

	result_loc = cwl_result[output_id]
	result_wps = os.path.join(wps_out_dir, os.path.split(result_loc)[-1])
	# FIXME: instead raise error for non-file output, (don't allow hacking output using string type)?
	# if any process provides an explicit URL, it should be handled by itself (we don't rewrite)
	if os.path.isfile(str(result_loc)):
	self.logger.warning("[DEPRECATED] Process output '%s' defined as CWL type other than File will "
	"be unsupported in a future release.", output_id)
	if os.path.realpath(result_loc) != os.path.realpath(result_wps):
	self.logger.info("Moving: [%s] -> [%s]", result_loc, result_wps)
	shutil.move(result_loc, result_wps)
	self.response.outputs[output_id].data = result_wps
	self.logger.info("Resolved WPS output [%s]: [%s]", output_id, result_wps)

This allows output 'string' type to refer to some actual file as literal data, but makes it hard to maintain and predict behavior of the application execution as we still need to adjust internal paths in order to make it available on WPS-outputs URL. It is even more complicated when an actual string should be returned from a given process (which action to take cannot be guaranteed).

To motivate correct writing of CWL application packages, we should enforce using File for such references. A string will simply be returned as is, just like any other literal data output.

Relates to DAC-533

[fmigneault]

Fixed by #360
Diff: https://github.com/crim-ca/weaver/pull/360/files#diff-ce41af74805c1d891a393bd1488434a450041ca7cc7df4f3532b4e516badf656R1408-R1413