Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some ApiGateway managed resources have no controller registered #1573

Closed
eapri opened this issue Nov 16, 2022 · 2 comments
Closed

Some ApiGateway managed resources have no controller registered #1573

eapri opened this issue Nov 16, 2022 · 2 comments
Labels
bug Something isn't working stale

Comments

@eapri
Copy link

eapri commented Nov 16, 2022

What happened?

I successfully composed and apigateway.aws.crossplane.io/v1alpha1 Integration resource like this:

apiVersion: apigateway.aws.crossplane.io/v1alpha1
kind: Integration
metadata:
  name: a-private-any-intergration
spec:
  forProvider:
    resourceId: some-resource-id
    restApiId: some-rest-api-id
    region: some-region
    connectionType: VPC_LINK
    httpMethod: ANY
    integrationHTTPMethod: ANY    
    type_: HTTP_PROXY
    uri: [https://www.example.com/{proxy}](https://www.example.com/%7Bproxy%7D)
  providerConfigRef:
    name: provider-aws

Then I noticed that this resources is not evaluated by a controller.

When take a look in the File: https://github.com/crossplane-contrib/provider-aws/blob/master/pkg/controller/aws.go only certain apigatewayV1 resources seem to be registered. The following apigatewayV1 resources seem to be missing here:

  • apikey
  • authorizer
  • basepathmapping
  • deployment
  • documentationpart
  • documentationversion
  • domainname
  • gatewayresponse
  • integration
  • integrationresponse
  • methodresponse
  • model
  • requestvalidator
  • stage
  • usageplan
  • usageplankey
  • vpclink

ApiGatewayV1 managed resources like RestApi, Resource and Method are evaluated like I expected.

How can we reproduce it?

Create an apigateway.aws.crossplane.io/v1alpha1 Integration resource like mentioned above.

What environment did it happen in?

Crossplane version:

  • AWS EKS 1.21
  • PROVIDER-AWS V0.31.0
  • CROSSPLANE v1.9.1-stable
@eapri eapri added the bug Something isn't working label Nov 16, 2022
@github-actions
Copy link

github-actions bot commented Aug 8, 2023

Crossplane does not currently have enough maintainers to address every issue and pull request. This issue has been automatically marked as stale because it has had no activity in the last 90 days. It will be closed in 14 days if no further activity occurs. Leaving a comment starting with /fresh will mark this issue as not stale.

@github-actions github-actions bot added the stale label Aug 8, 2023
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Aug 23, 2023
@maithilee25
Copy link

/fresh Is there any update or resolution for this issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working stale
Projects
None yet
Development

No branches or pull requests

2 participants