fix(rds): Infer cache secret namespace from pod environment #1893
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
This adds a function that infers the namespace of the RDS password cache secret from the following locations (in order):
POD_NAMESPACE
env var/var/run/secrets/kubernetes.io/serviceaccount/namespace
filecrossplane-system
Until now
crossplane-system
was the hardcoded value.Fixes #1834
Please note that this might cause a regeneration of passwords if the provider is running in another namespace than
crossplane-system
, but, due to the change, is now looking for the secret in another namespace where it does not exist.I have:
make reviewable test
to ensure this PR is ready for review.How has this code been tested
n.a.