Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(transfer): implement isUpToDate for transfer server #2151

Merged

Conversation

kkendzia
Copy link
Contributor

@kkendzia kkendzia commented Jan 23, 2025

Description of your changes

Implementation of isUpToDate function for Transfer Server.

I have:

  • Read and followed Crossplane's contribution process.
  • Run make reviewable test to ensure this PR is ready for review.

How has this code been tested

Locally ran provider for verification and unit test

@kkendzia kkendzia force-pushed the feat/transfer_server_isuptodate branch from 63926df to 4f34868 Compare January 24, 2025 06:53
@MisterMX
Copy link
Collaborator

MisterMX commented Feb 3, 2025

Needs rebase on #2154

Also, please adjust PR title and commit message to CC conventions feat(transfer): ...

@kkendzia kkendzia force-pushed the feat/transfer_server_isuptodate branch from 4f34868 to db73779 Compare February 3, 2025 11:05
@kkendzia kkendzia changed the title feat: implement isUpToDate for transfer server feat(transfer): implement isUpToDate for transfer server Feb 3, 2025
@kkendzia kkendzia force-pushed the feat/transfer_server_isuptodate branch from eef534f to e7229c6 Compare February 5, 2025 12:13
@kkendzia kkendzia force-pushed the feat/transfer_server_isuptodate branch from e7229c6 to ae2520d Compare February 5, 2025 13:06
@MisterMX MisterMX merged commit 93bb8ff into crossplane-contrib:master Feb 7, 2025
8 checks passed
Copy link

github-actions bot commented Feb 7, 2025

Backport failed for release-0.51, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally.

git fetch origin release-0.51
git worktree add -d .worktree/backport-2151-to-release-0.51 origin/release-0.51
cd .worktree/backport-2151-to-release-0.51
git checkout -b backport-2151-to-release-0.51
ancref=$(git merge-base ea641216a667254a19a0fdc08f7f496a145f6213 ae2520d171a786d8779c2954e53565cb7d0d6e2c)
git cherry-pick -x $ancref..ae2520d171a786d8779c2954e53565cb7d0d6e2c

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants