Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dependency between assemble and macappbundle tasks #70

Open
dcabasson opened this issue Sep 30, 2019 · 0 comments
Open

Remove dependency between assemble and macappbundle tasks #70

dcabasson opened this issue Sep 30, 2019 · 0 comments

Comments

@dcabasson
Copy link

Specifically remove the block:

project.afterEvaluate{
          if (Os.isFamily(Os.FAMILY_MAC)) {
              project.getTasksByName("assemble", true).each{ t -> t.dependsOn(dmgTask) }
          } else {
              project.getTasksByName("assemble", true).each{ t -> t.dependsOn(zipTask) }
          }
        }

Not all the users of the plugin might want those dependencies attached to the assemble tasks. It's trivial to add the dependency in the build if needed, but impossible to remove it as of Gradle 6+ (see https://docs.gradle.org/5.0/release-notes.html#deprecations )

Other similar plugins such as the Gradle Application plugin do not create similar link between distTar/distZip and the assemble task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant