Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem: cachix not found on 1.7 #1295

Closed
wants to merge 1 commit into from

Conversation

mmsqe
Copy link
Collaborator

@mmsqe mmsqe commented Jan 15, 2024

ping on 1.6.1, for more info:
cachix/cachix@v1.6.1...v1.7

👮🏻👮🏻👮🏻 !!!! REFERENCE THE PROBLEM YOUR ARE SOLVING IN THE PR TITLE AND DESCRIBE YOUR SOLUTION HERE !!!! DO NOT FORGET !!!! 👮🏻👮🏻👮🏻

PR Checklist:

  • Have you read the CONTRIBUTING.md?
  • Does your PR follow the C4 patch requirements?
  • Have you rebased your work on top of the latest master?
  • Have you checked your code compiles? (make)
  • Have you included tests for any non-trivial functionality?
  • Have you checked your code passes the unit tests? (make test)
  • Have you checked your code formatting is correct? (go fmt)
  • Have you checked your basic code style is fine? (golangci-lint run)
  • If you added any dependencies, have you checked they do not contain any known vulnerabilities? (go list -json -m all | nancy sleuth)
  • If your changes affect the client infrastructure, have you run the integration test?
  • If your changes affect public APIs, does your PR follow the C4 evolution of public contracts?
  • If your code changes public APIs, have you incremented the crate version numbers and documented your changes in the CHANGELOG.md?
  • If you are contributing for the first time, please read the agreement in CONTRIBUTING.md now and add a comment to this pull request stating that your PR is in accordance with the Developer's Certificate of Origin.

Thank you for your code, it's appreciated! :)

Summary by CodeRabbit

  • Chores
    • Improved build process with enhanced package management.

@mmsqe mmsqe requested a review from a team as a code owner January 15, 2024 04:08
@mmsqe mmsqe requested review from yihuang and thomas-nguy and removed request for a team January 15, 2024 04:08
Copy link
Contributor

coderabbitai bot commented Jan 15, 2024

Walkthrough

The changes involve the addition of an installCommand in the workflow configuration for both build and test pipelines. This new command is specifically for the installation of cachix, which suggests an enhancement in the caching mechanism used during continuous integration processes.

Changes

File Path Change Summary
.github/workflows/build.yml Added installCommand for cachix install
.github/workflows/test.yml Added installCommand for cachix install

Poem

🐇 "In workflows so vast and wide,
A tweak has been made with pride.
Cachix now joins the fray,
To speed our CI day by day." 🚀✨

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit-tests for this file.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit tests for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository from git and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit tests.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between ea65bfa and 6daa21c.
Files selected for processing (2)
  • .github/workflows/build.yml (1 hunks)
  • .github/workflows/test.yml (2 hunks)
Additional comments: 2
.github/workflows/test.yml (1)
  • 47-47: The installCommand specifies version 1.6.1 of cachix, which seems to contradict the PR title that mentions an issue with cachix not being found on 1.7. Please verify that this is the intended version to install.
.github/workflows/build.yml (1)
  • 152-152: The installCommand specifies version 1.6.1 of cachix, which seems to contradict the PR title that mentions an issue with cachix not being found on 1.7. Please verify that this is the intended version to install.

Copy link

codecov bot commented Jan 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ea65bfa) 15.98% compared to head (6daa21c) 15.30%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1295      +/-   ##
==========================================
- Coverage   15.98%   15.30%   -0.68%     
==========================================
  Files          80       80              
  Lines        6201     6201              
==========================================
- Hits          991      949      -42     
- Misses       5130     5179      +49     
+ Partials       80       73       -7     

see 4 files with indirect coverage changes

@mmsqe mmsqe requested a review from JayT106 January 19, 2024 01:25
@@ -149,6 +149,7 @@ jobs:
with:
name: cronos
extraPullNames: dapp
installCommand: "nix-env --quiet -j8 -iA cachix -f https://cachix.org/api/v1/install/1.6.1"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what's the error without this line?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think they fix it last friday, can close this now

@mmsqe mmsqe closed this Jan 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants