-
Notifications
You must be signed in to change notification settings - Fork 243
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Problem: cachix not found on 1.7 #1295
Conversation
ping on 1.6.1, for more info: cachix/cachix@v1.6.1...v1.7
WalkthroughThe changes involve the addition of an Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Status
Actionable comments generated: 0
Configuration used: CodeRabbit UI
Files selected for processing (2)
- .github/workflows/build.yml (1 hunks)
- .github/workflows/test.yml (2 hunks)
Additional comments: 2
.github/workflows/test.yml (1)
- 47-47: The
installCommand
specifies version 1.6.1 of cachix, which seems to contradict the PR title that mentions an issue with cachix not being found on 1.7. Please verify that this is the intended version to install..github/workflows/build.yml (1)
- 152-152: The
installCommand
specifies version 1.6.1 of cachix, which seems to contradict the PR title that mentions an issue with cachix not being found on 1.7. Please verify that this is the intended version to install.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1295 +/- ##
==========================================
- Coverage 15.98% 15.30% -0.68%
==========================================
Files 80 80
Lines 6201 6201
==========================================
- Hits 991 949 -42
- Misses 5130 5179 +49
+ Partials 80 73 -7 |
@@ -149,6 +149,7 @@ jobs: | |||
with: | |||
name: cronos | |||
extraPullNames: dapp | |||
installCommand: "nix-env --quiet -j8 -iA cachix -f https://cachix.org/api/v1/install/1.6.1" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what's the error without this line?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think they fix it last friday, can close this now
ping on 1.6.1, for more info:
cachix/cachix@v1.6.1...v1.7
👮🏻👮🏻👮🏻 !!!! REFERENCE THE PROBLEM YOUR ARE SOLVING IN THE PR TITLE AND DESCRIBE YOUR SOLUTION HERE !!!! DO NOT FORGET !!!! 👮🏻👮🏻👮🏻
PR Checklist:
make
)make test
)go fmt
)golangci-lint run
)go list -json -m all | nancy sleuth
)Thank you for your code, it's appreciated! :)
Summary by CodeRabbit