diff --git a/core/src/main/java/org/apache/accumulo/core/fate/Fate.java b/core/src/main/java/org/apache/accumulo/core/fate/Fate.java index e2ffce3a0b5..dd521e3a0c7 100644 --- a/core/src/main/java/org/apache/accumulo/core/fate/Fate.java +++ b/core/src/main/java/org/apache/accumulo/core/fate/Fate.java @@ -541,7 +541,7 @@ public FateId startTransaction() { public void seedTransaction(FateOperation fateOp, FateKey fateKey, Repo repo, boolean autoCleanUp) { try (var seeder = store.beginSeeding()) { - seeder.attemptToSeedTransaction(fateOp, fateKey, repo, autoCleanUp); + var unused = seeder.attemptToSeedTransaction(fateOp, fateKey, repo, autoCleanUp); } } diff --git a/core/src/main/java/org/apache/accumulo/core/fate/FateStore.java b/core/src/main/java/org/apache/accumulo/core/fate/FateStore.java index 5174fcc259f..6854aec7136 100644 --- a/core/src/main/java/org/apache/accumulo/core/fate/FateStore.java +++ b/core/src/main/java/org/apache/accumulo/core/fate/FateStore.java @@ -54,8 +54,12 @@ public interface FateStore extends ReadOnlyFateStore { interface Seeder extends AutoCloseable { /** - * Seeds a transaction with the given repo if it does not exist. A fateId will be derived from - * the fateKey. If seeded, sets the following data for the fateId in the store. + * Attempts to seed a transaction with the given repo if it does not exist. A fateId will be + * derived from the fateKey. If seeded, sets the following data for the fateId in the store. + * + * TODO: Support completing futures later in close method The current version will always return + * with a CompleteableFuture that is already completed. Future version will process will + * complete in the close() method for the User store. * *
    *
  • Set the fate op
  • @@ -70,13 +74,13 @@ interface Seeder extends AutoCloseable { * and empty optional otherwise. If there was a failure this could return an empty * optional when it actually succeeded. */ - // For UserFateStore this would create a conditional mutation and add it to the conditional - // writer CompletableFuture> attemptToSeedTransaction(Fate.FateOperation fateOp, FateKey fateKey, Repo repo, boolean autoCleanUp); - // This would check the status of all added conditional mutations, retry unknown, and then close - // the conditional writer. + // TODO: Right now all implementations do nothing + // Eventually this would check the status of all added conditional mutations, + // retry unknown, and then close the conditional writer. + @Override void close(); }