Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IncludeTable/ExcludeTable - appropriate noun? #60

Open
batesm opened this issue Mar 23, 2022 · 3 comments
Open

IncludeTable/ExcludeTable - appropriate noun? #60

batesm opened this issue Mar 23, 2022 · 3 comments

Comments

@batesm
Copy link

batesm commented Mar 23, 2022

Using EntityFrameworkCore we can map an entity to multiple tables or multiple entities to a single table (TPT, TPH etc)

This made me wonder about the usage of nouns like “table” and “column” (when configuring IncludeTable/ExcludeTable). Perhaps a better and more consistent fit with EFCore domain language would be “entity” (or “entity type”) and “property”.

Hence IncludeEntity/ExcludeEntity instead…?

There is not always a one to one mapping regards entity to table.

@csharpfritz
Copy link
Owner

I'm not sold on this, as I think there are other storage shapes like Collection and Fields for other NoSQL storage types when we think of the repository pattern features.

@batesm
Copy link
Author

batesm commented Apr 4, 2022

I guess this means you’re planning to unify the “API config” classes? Currently there is one for DbContext and one for Json.

Anyway, I think the concept of Instant APIs is great and when it’s matured could be a very valuable tool to use 🙂

@csharpfritz
Copy link
Owner

Yes, the two configs should be merged and I think a future move towards a simple API that defines the storage mechanism as a Repository, EF Context, some other database provider, a JSON file, or some other format is a welcome change

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants