Skip to content
This repository has been archived by the owner on May 29, 2018. It is now read-only.

finalize first version of speaker-details page and speaker-list component #52

Closed
usefulthink opened this issue Jan 20, 2017 · 5 comments
Assignees

Comments

@usefulthink
Copy link
Member

No description provided.

@usefulthink usefulthink self-assigned this Jan 20, 2017
Kriesse added a commit that referenced this issue Jan 24, 2017
@Kriesse
Copy link
Member

Kriesse commented Jan 25, 2017

@usefulthink

I added a speaker list component, and three test speaker files with generic content (no more del Rey).
The component is included on the homepage, on /speakers, and on single speaker pages.
The corresponding styles are here.

Notes

  • Each speaker now has color and bg, as the mockup specifies varying colors for both text and background. As the text-color is often white, the color for the header title on a single speaker page now uses the bg color (as white would be not visible on the light header background).

  • I am seeing a weird broken page with unescaped text (?) when I open a single speaker page. Not exactly sure how to reproduce. Opening the page again in a new tab sometimes fixes it.
    image

Preview: Desktop

image

Preview: Mobile

image

usefulthink pushed a commit that referenced this issue Feb 13, 2017
@RalloTubbs
Copy link

details visual feedback:

  • shadow behing Una looks cut

screenshot 2017-02-22 08 40 14

  • boxes could be higher, because in balance to the other elements they look small, we don't have to make it that high, maybe 20 higher would help, if the fontsize stays like this
  • boxes always left aligned: we could always add a next box saying tba

screenshot 2017-02-22 08 34 55

- still the names could be bigger?
  • the box on detailpage could have more meat like this

screenshot 2017-02-22 08 39 01

@lukaszklis
Copy link
Member

lukaszklis commented Feb 22, 2017

@RalloTubbs if you don’t mind, I’d like to close this issue and create a new ones.

@lukaszklis
Copy link
Member

Split into #59, #60, #61

@RalloTubbs
Copy link

@lukaszklis please do

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants