Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Client Core: Add meta to TS types for cubes and views #7523

Closed
hannosgit opened this issue Dec 13, 2023 · 4 comments · Fixed by #7527
Closed

Client Core: Add meta to TS types for cubes and views #7523

hannosgit opened this issue Dec 13, 2023 · 4 comments · Fixed by #7527
Labels
client:core Issues relating to the JavaScript client SDK data modeling:views enhancement New feature proposal help wanted Community contributions are welcome.

Comments

@hannosgit
Copy link
Contributor

Is your feature request related to a problem? Please describe.
MR #7327 added a meta property to views and cubes, but this change is not yet reflected in the TypeScript types of the Core Client.

Describe the solution you'd like
Add the meta property to views and cubes in the TypeScript types of the Core Client.
@igorlukanin igorlukanin added enhancement New feature proposal client:core Issues relating to the JavaScript client SDK data modeling:views help wanted Community contributions are welcome. labels Dec 13, 2023
@github-actions GitHub Actions
Copy link

If you are interested in working on this issue, please leave a comment below and we will be happy to assign the issue to you.
If this is the first time you are contributing a Pull Request to Cube.js, please check our contribution guidelines.
You can also post any questions while contributing in the #contributors channel in the Cube.js Slack.

@igorlukanin
Copy link
Member

Good call @hannosgit! Is it something that you might be willing to contribute?

@mharrisb1 mharrisb1 mentioned this issue Dec 13, 2023
Merged
@hannosgit
Copy link
Contributor Author

I was about to create a mini Pull Request for this, but it seems that @mharrisb1 was faster than me. 😄
Thank you @mharrisb1 for this and the original Pull Request!

@mharrisb1
Copy link
Contributor

@hannosgit np 👍 I should have thought about this in the original PR so thanks for catching

@ovr ovr closed this as completed in #7527 Dec 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
client:core Issues relating to the JavaScript client SDK data modeling:views enhancement New feature proposal help wanted Community contributions are welcome.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore(client-core): add meta field to cube type def mharrisb1/cube
3 participants
@igorlukanin @mharrisb1 @hannosgit