Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Borders not removed from Mushroom Cards in Vertical Stack #60

Open
2 tasks done
WorldOfMaze opened this issue Aug 5, 2023 · 4 comments
Open
2 tasks done

Borders not removed from Mushroom Cards in Vertical Stack #60

WorldOfMaze opened this issue Aug 5, 2023 · 4 comments
Labels
bug Something isn't working

Comments

@WorldOfMaze
Copy link

Checklist:

  • I updated to the latest version available
  • I cleared the cache of my browser

Release with the issue:
Stack in Card v0.2.0; Home Assistant 2023.8.1

Last working release (if known):
New installation of Stack in Card

Browser and Operating System:
Firefox 115.0.2 on Windows 11
Home Assistant Companion App on Android 14

Description of problem:
When combining a Mushroom Climate Card and a Mushroom Entity Card into a vertical stack, the borders of both Mushroom cards are not hidden as expected.

image

The YAML for this card is:

type: custom:stack-in-card
mode: vertical
cards:
  - type: custom:mushroom-climate-card
    entity: climate.master_bedroom
    name: Master Bedroom Thermostat
    hvac_modes:
      - heat_cool
      - heat
      - cool
      - 'off'
    show_temperature_control: true
    collapsible_controls: true
    fill_container: false
  - type: custom:mushroom-entity-card
    entity: sensor.master_bedroom_humidity
    name: Humidity

Javascript errors shown in the web inspector (if applicable):

card custom:stack-in-card Error: There is no cards parameter defined
    setConfig stack-in-card.js:204
    r create-element-base.ts:97
    h create-element-base.ts:111
    h create-element-base.ts:215
    c create-element-base.ts:172
    k create-card-element.ts:101
    value hui-stack-card.ts:102
    _cards hui-stack-card.ts:47
    value hui-stack-card.ts:46
    r create-element-base.ts:97
    h create-element-base.ts:140
    h create-element-base.ts:238
    c create-element-base.ts:172
    k create-card-element.ts:101
    value hui-stack-card.ts:102
    _cards hui-stack-card.ts:47
    value hui-stack-card.ts:46
    value hui-card-preview.ts:63
    performUpdate reactive-element.ts:1331
    scheduleUpdate reactive-element.ts:1263
    _$Ej reactive-element.ts:1235
[create-element-base.ts:182:12](https://raw.githubusercontent.com/home-assistant/frontend/20230802.0/src/panels/lovelace/create-element/create-element-base.ts)
    c create-element-base.ts:182
    k create-card-element.ts:101
    value hui-stack-card.ts:102
    _cards hui-stack-card.ts:47
    value hui-stack-card.ts:46
    r create-element-base.ts:97
    h create-element-base.ts:140
    h create-element-base.ts:238
    c create-element-base.ts:172
    k create-card-element.ts:101
    value hui-stack-card.ts:102
    _cards hui-stack-card.ts:47
    value hui-stack-card.ts:46
    value hui-card-preview.ts:63
    performUpdate reactive-element.ts:1331
    scheduleUpdate reactive-element.ts:1263
    _$Ej reactive-element.ts:1235

Additional information:

@WorldOfMaze WorldOfMaze added the bug Something isn't working label Aug 5, 2023
@matthewcbyington
Copy link

matthewcbyington commented Aug 21, 2023

I think I am also hitting this, and if so, the border corners also look a bit odd:

  1. The first (light) card is the only one inside a stack-in-card

type: custom:stack-in-card
cards:

  • type: custom:mushroom-light-card
    entity: light.matts_office_main_lights
    show_brightness_control: true
    collapsible_controls: true
image

@matthewcbyington
Copy link

Note that I do not experience the poor border UI and behavior depicted above with the vertical-stack-in-card, if that helps.

@pouzak
Copy link

pouzak commented Dec 3, 2023

Core version 2023.11.3, used this to remove borders:

type: custom:stack-in-card
mode: vertical
cards:
  - type: media-control
    entity: media_player.lg_webos_smart_tv
  - type: history-graph
    style: |
      ha-card {
      border: none;
      }
    entities:
      - entity: media_player.lg_webos_smart_tv
        name: ' '

@FilipeOS
Copy link

Card mod now only works with:
card_mod:
style:

not only style:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants