You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Problem summary
Accidentals are remade on streams that users may have already made accidentals for instead of short-circuiting. Discovered responding to #1667.
But even PartExporter.fixupNotationMeasured() is probably too late, given that fromGeneralObject() runs first, runs makeNotation, and neither streamStatus.accidentals nor streamStatus.haveAccidentalsBeenMade() is checked.
The text was updated successfully, but these errors were encountered:
music21 version
9.2.0b2
Problem summary
Accidentals are remade on streams that users may have already made accidentals for instead of short-circuiting. Discovered responding to #1667.
Steps to reproduce
Expected vs. actual behavior
Expected: no accidental
Actual: accidental
More information
PartExporter.fixupNotationMeasured() checks haveAccidentalsBeenMade():
music21/music21/musicxml/m21ToXml.py
Line 2866 in a938a8c
But makeAccidentals sets the property instead:
music21/music21/stream/makeNotation.py
Lines 1739 to 1740 in a938a8c
But even PartExporter.fixupNotationMeasured() is probably too late, given that fromGeneralObject() runs first, runs makeNotation, and neither
streamStatus.accidentals
norstreamStatus.haveAccidentalsBeenMade()
is checked.The text was updated successfully, but these errors were encountered: