Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Character health loss amount text #808

Closed
PavanLuca opened this issue Jul 22, 2023 · 3 comments · Fixed by #867
Closed

Character health loss amount text #808

PavanLuca opened this issue Jul 22, 2023 · 3 comments · Fixed by #867
Assignees
@Hrvt2
Labels
bug good first issue ux

Comments

@PavanLuca
Copy link

PavanLuca commented Jul 22, 2023 •
edited
Loading

When the character is hurt it shows the whole level damage taken so far instead of only the current hits damage.
Schermata da 2023-07-25 16-11-30
@cxong
Copy link
Owner

cxong commented Oct 1, 2024

Actor contains a field accumulatedDamage which stores this amount; it seems this never gets reset. It should be reset after a period of no change, say 1 second (Game.FPS ticks)

@Hrvt2
Copy link
Contributor

Hrvt2 commented Oct 9, 2024

I would like to try and solve this issue

@cxong
Copy link
Owner

cxong commented Oct 9, 2024

ok

@cxong cxong linked a pull request Dec 5, 2024 that will close this issue
Reset accumulatedDamage #808 #867
Merged
@cxong cxong moved this to In progress in C-Dogs SDL next release Dec 5, 2024
cxong pushed a commit that referenced this issue Dec 6, 2024
@Hrvt2
Reset accumulatedDamage #808 (#867)
38ae30a 
add variable damageCooldownTicks to Actor, in UpdateActorState reset Actor's accumulatedDamage if thier damageCooldownTicks is greater than one second
@cxong cxong closed this as completed in #867 Dec 6, 2024
@github-project-automation github-project-automation bot moved this from In progress to Done in C-Dogs SDL next release Dec 6, 2024
@Hrvt2 Hrvt2 mentioned this issue Dec 6, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Hrvt2 Hrvt2

Labels
bug good first issue ux
Projects
C-Dogs SDL next release
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Reset accumulatedDamage #808 Hrvt2/cdogs-sdl
3 participants
@cxong @PavanLuca @Hrvt2