Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accidentally adding new members #32

Open
juliegri opened this issue Sep 6, 2024 · 2 comments
Open

Accidentally adding new members #32

juliegri opened this issue Sep 6, 2024 · 2 comments
Labels
bug Something isn't working duplicate This issue or pull request already exists

Comments

@juliegri
Copy link

juliegri commented Sep 6, 2024

HEI!

It's too easy to accidentally add new members. After you've successfully added a new member their name stays in the input field - and if you right click this field the member gets added on more time. For usability's sake it should probably only be possible to add new members by clicking the "add"-button. plspls (btw. Eirik Noremsaune was added as a member 5 times heheh 🤭)

@EricSvebakk EricSvebakk added the duplicate This issue or pull request already exists label Sep 6, 2024
@EricSvebakk
Copy link
Member

EricSvebakk commented Sep 6, 2024

#30 Mentions this

@EricSvebakk EricSvebakk added the bug Something isn't working label Sep 6, 2024
@yrjarv
Copy link
Member

yrjarv commented Sep 26, 2024

I think I have a fix ready for this (querying the database for duplicates before creating new user). But how should we give the error message? I notice that other places the field with invalid values is marked in red, but I feel like a more detailed error message would be fitting here. We could of course just alert using the built-in alert() function, but what do you think @EricSvebakk?
PS: My fix won't solve #30 though, only this issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working duplicate This issue or pull request already exists
Projects
None yet
Development

No branches or pull requests

3 participants