Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove methods which are iterating over attributes inside clang #9

Open
soft-bagel-93 opened this issue Jan 13, 2020 · 0 comments
Open

Remove methods which are iterating over attributes inside clang #9

soft-bagel-93 opened this issue Jan 13, 2020 · 0 comments
Assignees
@soft-bagel-93
Labels
bug Something isn't working

Comments

@soft-bagel-93
Copy link

soft-bagel-93 commented Jan 13, 2020 •
edited
Loading

Unfortunately, things like #8 are non-effective, because:

  • We should iterate over all attributes in Clang to collect them (or their names) to container, and next iterate over this container in tool (cyberway-cpp).
  • Each of their is implementing for specific type of clang::Decl, when getAttrs() is universal.
    It is preferred to iterate all through getAttrs() in tool.
@soft-bagel-93 soft-bagel-93 self-assigned this Jan 13, 2020
@soft-bagel-93 soft-bagel-93 added the bug Something isn't working label Jan 13, 2020
soft-bagel-93 added a commit that referenced this issue Jan 13, 2020
@soft-bagel-93
Revert "Merge pull request #8 from cyberway/7-clang-getattrs-by-boost…
480905b 
…multifruit" for #9

This reverts commit 34a1f74, reversing
changes made to c731168.
soft-bagel-93 added a commit that referenced this issue Jan 13, 2020
@soft-bagel-93
Remove attributes iterating methods #9
c45b1a8
@soft-bagel-93 soft-bagel-93 mentioned this issue Jan 13, 2020
Merged
soft-bagel-93 added a commit that referenced this issue Jan 13, 2020
@soft-bagel-93
Merge pull request #10 from cyberway/9-attrs-fix
3fc3238 
 Remove attributes iterating methods #9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@soft-bagel-93 soft-bagel-93

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@soft-bagel-93