From 7a4a4d4eb5626670b1c30ebed065110b0b82e682 Mon Sep 17 00:00:00 2001 From: Merci Jacob <68013195+jacob-js@users.noreply.github.com> Date: Tue, 5 Nov 2024 15:06:06 +0200 Subject: [PATCH] Tweak the sidebar for a modern look and feel (#1313) * Tweak the sidebar for a modern look and feel * Many adjustments, including: using the bootstrap collapse components for collapsible items in the navbar, the sizing, and a bit on the look * Adjust unit tests * Adjust selenium tests * Fix selenium tests * Fix folder_list tests * Fix profiles tests * Fix settings tests * Fix servers tests --- modules/account/modules.php | 2 +- modules/calendar/modules.php | 2 +- modules/contacts/modules.php | 2 +- modules/core/output_modules.php | 61 +++++++++---------- modules/core/site.css | 56 +++++++++-------- modules/core/site.js | 26 ++++---- modules/developer/modules.php | 4 +- modules/feeds/modules.php | 8 +-- modules/history/modules.php | 2 +- modules/imap_folders/modules.php | 2 +- modules/keyboard_shortcuts/modules.php | 2 +- modules/pgp/modules.php | 2 +- modules/profiles/modules.php | 2 +- modules/smtp/modules.php | 4 +- modules/tags/modules.php | 2 +- tests/phpunit/modules/core/output_modules.php | 24 ++++---- .../modules/core/output_modules_debug.php | 4 +- tests/selenium/base.py | 12 +++- tests/selenium/folder_list.py | 26 ++++---- tests/selenium/login.py | 1 + tests/selenium/pages.py | 2 +- tests/selenium/profiles.py | 4 +- tests/selenium/send.py | 1 + tests/selenium/servers.py | 5 +- tests/selenium/settings.py | 12 ++-- tests/selenium/tags.py | 2 +- 26 files changed, 147 insertions(+), 123 deletions(-) diff --git a/modules/account/modules.php b/modules/account/modules.php index 122af5ad3c..8cd391907c 100644 --- a/modules/account/modules.php +++ b/modules/account/modules.php @@ -208,7 +208,7 @@ protected function output() { if ($this->get('internal_users')) { $res = ''; $this->concat('formatted_folder_list', $res); diff --git a/modules/calendar/modules.php b/modules/calendar/modules.php index f4a0db3a8a..4a34bc9bfd 100644 --- a/modules/calendar/modules.php +++ b/modules/calendar/modules.php @@ -132,7 +132,7 @@ class Hm_Output_calendar_page_link extends Hm_Output_Module { protected function output() { $res = ''; if ($this->format == 'HTML5') { diff --git a/modules/contacts/modules.php b/modules/contacts/modules.php index 1c559e7d97..3805b9ef43 100644 --- a/modules/contacts/modules.php +++ b/modules/contacts/modules.php @@ -203,7 +203,7 @@ class Hm_Output_contacts_page_link extends Hm_Output_Module { protected function output() { $res = ''; if ($this->format == 'HTML5') { diff --git a/modules/core/output_modules.php b/modules/core/output_modules.php index 1b4be14944..fc5ef0059e 100644 --- a/modules/core/output_modules.php +++ b/modules/core/output_modules.php @@ -15,15 +15,16 @@ class Hm_Output_search_from_folder_list extends Hm_Output_Module { * Add a search form to the top of the folder list */ protected function output() { - $res = ''; + $res .= ''. + ''; if ($this->format == 'HTML5') { return $res; } @@ -1320,14 +1321,14 @@ class Hm_Output_main_menu_start extends Hm_Output_Module { * Opens a div and unordered list tag */ protected function output() { - $res = '