Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Webpack 3 #5

Open
jnwng opened this issue Aug 29, 2017 · 0 comments
Open

Add support for Webpack 3 #5

jnwng opened this issue Aug 29, 2017 · 0 comments

Comments

@jnwng
Copy link

jnwng commented Aug 29, 2017

hello!

first of all, really appreciate the work here, once i found it i realized that i was the perfect solution for our performance issues building webpack applications in different locales. however, i had some trouble integrating it with webpack 3 (as well as supporting alternative resource paths).

while i have it working, im not sure what's the best interface for those improvements here (and if you even want to deal with webpack 3 support). you can see my fork here.

two things i added:

  1. an option to replace the resourcePath. we have a system here where we call
    require('i18n!nls/page.js') which should farm out to require('i18n!nls/{en,es,ru}/page.js'), whereas it looks like this was designed to do require('i18n!nls/en/page') -> require('i18n!nls/ru/page')
  2. the chunk output format was changed and so the string replace had to change as well.

if this support looks interesting to you, i'd be happy to split these two features into a PR here!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

1 participant