-
Notifications
You must be signed in to change notification settings - Fork 291
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Damus purple: add "learn more" link in app that leads to damus.io/purple website #1827
Comments
I will get started on this while I wait for the sandbox environment |
Update: So far I was able to make a rough draft of this landing page. Definitely not ready yet, but some good progress was made today!
@jb55, @alltheseas, please let me know if you have ideas/suggestions! |
90%+ traffic will be mobile. Looks like that's your last point. I'll provide comments when I can see the content on mobile 😅 |
On Sat, Dec 30, 2023 at 12:59:54AM -0800, Daniel D’Aquino wrote:
**Update:** So far I was able to make a rough draft of this landing page. Definitely not ready yet, but some good progress was made today!
looking good!
|
Status update!Previously in this ticket:
Today:
Draft preview: https://659619afa475881f5b888d57--legendary-dango-acb4d9.netlify.app/purple What is left:
|
Please feel free to critique or mention any issues that I might have missed in my list. I will keep working on what is missing. Thanks! |
Website works on mobile! It seems legible for my eyes that have a tough time with small text. When I click on the "Learn more" button the same page opens in a new tab. Maybe tapping this button can simply scroll down to the next section. Should we add a sub-header below the PURPLE title, and above the Subscribe button? e.g. PURPLE |
Good point, I need to hook up that button. Scroll down is a good action for it. I also need to remove the up-right arrow as it usually signifies "Open in a new tab"
I like that! I will add it in. I will build the acceptance criteria on the top with updated items |
Patches!Changes since my last update here
Big payment flow changeI changed the checkout flow to include npub authentication. I did this because I noticed the previous flows had the potential of causing lots of confusion and dissatisfaction. Why not the previous gift-able flow
We can make a flow for gifting later, but it needs extra care to avoid confusion Testing (and new demo)Due to changes being present in 3 different repos, I will post a video of my latest test/demo here: https://drive.google.com/file/d/1FGBkyFFWVAut12EVvbsoeW7C2jfLqfP4/view?usp=sharing The Patches
Other notes@jb55, @alltheseas, please let me know if I am missing anything, there is a lot going on here 😂 Thanks! |
From Jan 15 discussion:
|
Thanks @alltheseas for that list! I will complement your list with some other notes I have been taking while developing this
CC @jb55 |
@jb55, I am making the changes requested:
@jb55, are there any logs on your end of the LN node that might point to the reason why connection is failing? |
I tried connecting to:
The socket seems to close as soon as it is opened, with no data exchanged |
I will try using LNSocket on the client-side instead of LNMessage. LNMessage integrates better with the website's JS setup, but I am not sure how well that package is maintained. I will provide an update very soon |
On Mon, Jan 15, 2024 at 05:25:42PM -0800, Daniel D’Aquino wrote:
I tried connecting to:
- wss://ln.damus.io:9735
- ws://ln.damus.io:9735
The socket seems to close as soon as it is opened, with no data exchanged
You have to use the websockets port on the web:
ws://ln.damus.io:8324
In an https context ws:// is not allowed, so you have to use a
lightning-websockets proxy:
wss://proxy.lnlink.org/ln.damus.io
|
Thank you @jb55! I will try those and report back! |
@jb55, it worked! I had to use a workaround in LNMessage (Seems like the way they format proxied URLs is incorrect). I will see if I can open a quick ticket for this on that repo. But the workaround works, I was able to go through the overall flow. There is one issue with displaying the invoice that applies only on iOS, I will take a quick look at that |
Done: lnbc1QWFyb24/lnmessage#52
Found out the cause, and fixed it. 👍 I will test the flow 5 times to check robustness |
Testing complete , I also cleaned up my commits, prepared the patches, and sent them via email.
@jb55, please let me know if this looks good, or if any further changes are needed. Thanks! |
Created a placeholder task where we can organize further hardening work on the LN flow: #1892 |
The last patch of this ticket was pushed. Thanks @jb55! I documented follow-up work into two tickets: I believe all items in the acceptance criteria and all items discussed are covered in the patches pushed or the tickets mentioned above. Closing ticket. @alltheseas, @jb55, please feel free to reopen if I missed anything. Thanks! |
-add link to damus.io/purple in app
-add landing page
@danieldaquino
related to
subscribe on website via sats #1754
Acceptance criteria
The text was updated successfully, but these errors were encountered: