Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Audit Log #229

Closed
ptman opened this issue Oct 21, 2018 · 6 comments · Fixed by #2868
Closed

Audit Log #229

ptman opened this issue Oct 21, 2018 · 6 comments · Fixed by #2868
Labels
enhancement New feature or request low priority Won't fix anytime soon, but will accept PR if provided

Comments

@ptman
Copy link

ptman commented Oct 21, 2018

I would very much like to have an audit log in bitwarden. It would be good to be able to find out later who has viewed or changed a certain item and when. Also which items a person has viewed so that those passwords can be changed. It should probably be structured in some way in order to allow queries. Stored in the DB? Or just output as JSON-object per line to a log-file or similar destination?

I know bitwarden enterprise offers some kind of audit log. Does the vault app make use of api endpoints to view it?

@mprasil
Copy link
Contributor

mprasil commented Oct 21, 2018

Hi Paul, a lot of those things aren't possible due to the nature of how Bitwarden works. The ciphers are just synced to the client - all in one request - and then viewing is completely client-side, so server has no such information. As far as you should be concerned, all passwords could be potentially viewed by the client once the ciphers have been synced.

As for saving, we could perhaps log those events optionally with user name? There's no such interface in Vault interface though, so someone would have to create interface just for that or it would be only down to logs or DB records.

If you're really concerned about changing passwords once the user is removed from organization or his privilege removed, maybe something like HashiCorp's Vault would be a better fit? Though that one is meant to be used via API mostly.

@mprasil mprasil added the enhancement New feature or request label Oct 21, 2018
@ptman
Copy link
Author

ptman commented Oct 21, 2018

Thanks, I understand. I wonder what bitwarden enterprise audit log looks like. And while vault is good, and I use it for some stuff, bitwarden is useful for other stuff.

Also, some web password managers offer support for automatically changing passwords on supported sites: https://blog.lastpass.com/2014/12/introducing-auto-password-changing-with.html/ . That would be awesome in combination with a proper audit log, but I understand that it's a lot of work and probably needs integration from the client as well.

@mprasil
Copy link
Contributor

mprasil commented Oct 21, 2018

Yeah, unfortunately (or luckily, depending who you ask 😉) bitwarden works with almost zero knowledge about the stored data. This includes things like password name or for which site it is. Essentially everything except the owner id is encrypted. So things like automatic password change would have to be implemented on the client side and you need to ask for that feature upstream.

As for API call log, I guess we could log which user called which API if the call is authenticated. This would be probably something you would have to enable via configuration option and with the understanding that there's generally very little that you would see anyways as the server usually has very little knowledge by design.

@ptman
Copy link
Author

ptman commented Oct 21, 2018

Yes, I understood that from you explanation. But bitwarden enterprise does record an audit log. The web vault code makes references to accessEvents, eventLogs, useEvents, etc. and there's EventService, apparently for translating events when viewing the history. But how are they recorded? Can an API be implemented so that the clients will take care of that?

@mprasil mprasil added the low priority Won't fix anytime soon, but will accept PR if provided label Oct 22, 2018
@mprasil
Copy link
Contributor

mprasil commented Oct 22, 2018

This would probably require some significant effort - most likely also implementing actual admin interface. I think we will need to find someone motivated enough to submit a PR, which would be very welcome provided it's an optional feature that can be turned on.

@dani-garcia
Copy link
Owner

To keep the issue tracker more focused, I'm closing this issue in favor of the meta issue at #246.

BlackDex added a commit to BlackDex/vaultwarden that referenced this issue Nov 20, 2022
This PR adds event/audit logging support for organizations.
By default this feature is disabled, since it does log a lot and adds
extra database transactions.

All events are touched except a few, since we do not support those
features (yet), like SSO for example.

This feature is tested with multiple clients and all database types.

Fixes dani-garcia#229
BlackDex added a commit to BlackDex/vaultwarden that referenced this issue Nov 20, 2022
This PR adds event/audit logging support for organizations.
By default this feature is disabled, since it does log a lot and adds
extra database transactions.

All events are touched except a few, since we do not support those
features (yet), like SSO for example.

This feature is tested with multiple clients and all database types.

Fixes dani-garcia#229
BlackDex added a commit to BlackDex/vaultwarden that referenced this issue Nov 27, 2022
This PR adds event/audit logging support for organizations.
By default this feature is disabled, since it does log a lot and adds
extra database transactions.

All events are touched except a few, since we do not support those
features (yet), like SSO for example.

This feature is tested with multiple clients and all database types.

Fixes dani-garcia#229
BlackDex added a commit to BlackDex/vaultwarden that referenced this issue Nov 27, 2022
This PR adds event/audit logging support for organizations.
By default this feature is disabled, since it does log a lot and adds
extra database transactions.

All events are touched except a few, since we do not support those
features (yet), like SSO for example.

This feature is tested with multiple clients and all database types.

Fixes dani-garcia#229
dani-garcia pushed a commit that referenced this issue Dec 1, 2022
This PR adds event/audit logging support for organizations.
By default this feature is disabled, since it does log a lot and adds
extra database transactions.

All events are touched except a few, since we do not support those
features (yet), like SSO for example.

This feature is tested with multiple clients and all database types.

Fixes #229
dani-garcia pushed a commit that referenced this issue Dec 1, 2022
This PR adds event/audit logging support for organizations.
By default this feature is disabled, since it does log a lot and adds
extra database transactions.

All events are touched except a few, since we do not support those
features (yet), like SSO for example.

This feature is tested with multiple clients and all database types.

Fixes #229
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request low priority Won't fix anytime soon, but will accept PR if provided
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants