Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

URL not getting opened in new tab #15

Open
aswiinraviprakash opened this issue Feb 11, 2019 · 4 comments
Open

URL not getting opened in new tab #15

aswiinraviprakash opened this issue Feb 11, 2019 · 4 comments

Comments

@aswiinraviprakash
Copy link

When using blankshield to open a url in new Tab, the url is being blocked in chrome browser. It works fine in all other browser.

@Manours
Copy link

Manours commented Feb 18, 2019

I've got the same problem since Chrome 72.
Maybe because of that : https://www.chromestatus.com/feature/5989473649164288

@budley
Copy link

budley commented Feb 20, 2019

Same here - the library seems to be included in a WordPress security plugin called iThemes Security and so is breaking lots of sites via that (well, Chrome's change is - not the author's fault). If it can't be fixed could you let us know please then I can maybe let iThemes know so they can pull that feature (that many people might not be aware is causing their sites problems!). Thanks.

@TimothyBJacobs
Copy link

@budley We're pushing a fix to add the noopener rel to links instead of using blankshield for browsers that support the noopener property.

@meeq
Copy link

meeq commented Feb 21, 2019

https://bugs.chromium.org/p/chromium/issues/detail?id=844455

https://html.spec.whatwg.org/#apis-for-creating-and-navigating-browsing-contexts-by-name

The window open steps, given a string url, a string target, and a string features, are as follows:

  1. If the event loop's termination nesting level is nonzero, return null.

I assume this is happening because the iframe is removed immediately after it's added, which Chrome now considers a pop-up during unload:

blankshield/blankshield.js

Lines 187 to 190 in 6e208bf

iframeDoc.body.appendChild(script);
newWin = iframe.contentWindow.child;
document.body.removeChild(iframe);

Edit: Even if L190 is removed, the pop-up blocker is still triggered.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants