Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Plugin to TypeScript and Simplify Logic for Improved Prisma Integration #35

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

deko96
Copy link

@deko96 deko96 commented Sep 26, 2024

I came across this plugin while working on a project where Prisma integration with Serverless was becoming quite a challenge. This plugin was already easing some of the pain points I had with Prisma, but I found that a few tweaks could better suit my specific needs.

As part of my contribution:

  • I refactored the plugin from JavaScript to TypeScript to improve type safety and code maintainability.
  • Wherever possible, I simplified the logic to make it easier to follow and maintain.
  • I also refactored the tests, ensuring broader coverage and better alignment with the updated code.
  • Fixes Increased the zip size #21

There is some flakiness in handling the pathing parameters, and I believe there is room for improvement in that area in future releases. Unfortunately, due to time constraints, I’m unable to proceed further with development on this particular project.

I hope this PR can receive a review from @danieluhm2004 and get released soon, as I believe these changes would benefit other users as well!

Thanks for the great work on the original plugin, and I’m looking forward to your feedback.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Increased the zip size
1 participant