Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spotify use chromium for video ad #17

Open
021hossein opened this issue Dec 16, 2021 · 2 comments
Open

spotify use chromium for video ad #17

021hossein opened this issue Dec 16, 2021 · 2 comments

Comments

@021hossein
Copy link

Spotify use chromium for videos ad, but the extension mutes just Spotify.

Screenshot from 2021-12-16 21-39-45

@021hossein 021hossein changed the title spotify use chromium for videos ad spotify use chromium for video ad Dec 16, 2021
@bmaupin
Copy link
Contributor

bmaupin commented Jun 15, 2023

I just saw a video ad so I dumped the MPRIS data. Looks like the filter for mpris:trackid should still work, so it would just be the mixer sink filter that would need to be modified. @danigm Does it seem feasible to update the mixer sink filter to include chromium as well? I'm trying to think of what the unintended effects would be ...

Here's the MPRIS data dump:

$ dbus-send --print-reply --dest=org.mpris.MediaPlayer2.spotify /org/mpris/MediaPlayer2 org.freedesktop.DBus.Properties.Get  string:'org.mpris.MediaPlayer2.Player' string:'Metadata'
method return time=1686840708.549485 sender=:1.438 -> destination=:1.444 serial=67 reply_serial=2
   variant       array [
         dict entry(
            string "mpris:trackid"
            variant                string "/com/spotify/ad/252fb46a7c740baa771dc45139abe654"
         )
         dict entry(
            string "mpris:length"
            variant                uint64 30054000
         )
         dict entry(
            string "mpris:artUrl"
            variant                string ""
         )
         dict entry(
            string "xesam:album"
            variant                string ""
         )
         dict entry(
            string "xesam:albumArtist"
            variant                array [
                  string ""
               ]
         )
         dict entry(
            string "xesam:artist"
            variant                array [
                  string ""
               ]
         )
         dict entry(
            string "xesam:autoRating"
            variant                double 0
         )
         dict entry(
            string "xesam:discNumber"
            variant                int32 0
         )
         dict entry(
            string "xesam:title"
            variant                string "McDonald's"
         )
         dict entry(
            string "xesam:trackNumber"
            variant                int32 0
         )
         dict entry(
            string "xesam:url"
            variant                string "https://open.spotify.com/ad/252fb46a7c740baa771dc45139abe654"
         )
      ]

@danigm
Copy link
Owner

danigm commented Jun 16, 2023

I don't know if it's possible to detect which chromium is the one related to spotify... In other case, muting all chromiums could be a solution, I think it's not a common user case to have music and something else in chromium browser, but to solve that user case maybe we can add a configuration to enable/disable the chromium mute.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants