Skip to content

Commit

Permalink
Refactor BoundBody into BoundRequestBody
Browse files Browse the repository at this point in the history
Moves all the logic realted to getting the request body associated
with the request into a separate mod called client::request_bodies. At
least all the tests are there and the code is more organized.

However, this refactor is important because of two reasons:

* First, it prepares BoundRequestBody to receive files. The functions
  now receive the whole EndpointData. In order to implement file
  attachment this will come handy.

* Second, as part of the deprecation of CarteroError, it introduces a
  new kind of error called RequestPreconditionError. Currently it is a
  subtype of CarteroError to make the existing code compatible, but
  because it's a separate enum, it will be easy to unlink once that
  code is touched too.
  • Loading branch information
danirod committed Feb 27, 2025
1 parent 329c8d1 commit b0e2972
Show file tree
Hide file tree
Showing 5 changed files with 552 additions and 349 deletions.
Loading

0 comments on commit b0e2972

Please sign in to comment.