-
-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🔗 feat: Enhance Share Functionality, Optimize DataTable & Fix Critical Bugs #5220
Open
berry-13
wants to merge
11
commits into
main
Choose a base branch
from
refactor/share-link
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
berry-13
changed the title
🔗 feat: Enhance Share Link functionality with QR Code, conditional rendering, and improved pagination
🔗 feat: Enhance Share Functionality, Optimize DataTable & Fix Critical Bugs
Jan 12, 2025
Thanks @berry-13 Please un-draft and mention me when ready! Also:
|
…hare link; feat: refresh link
…parameters and response structure
…place pageNumber with cursor for improved data fetching
… shared link model and update related components
…elete mutation and confirmation dialog
…d search functionality; update search handling in API and localization
…ty and loading states, optimize AnimatedSearchInput, and refine DataTable scrolling behavior
berry-13
force-pushed
the
refactor/share-link
branch
from
January 15, 2025 22:08
7e28df2
to
c255687
Compare
@danny-avila ready |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Description:
🎯 Objective: Significantly enhance the
Share
functionality, optimize data handling, and resolve critical bugs💥 Error Handling Improvements:
ShareServiceError
class for detailed error management withinapi/models/Share.js
⚡ ID Anonymization Optimization:
api/models/Share.js
🚀 API Enhancements:
getSharedLinks
to enable cursor-based pagination and search inapi/models/Share.js
api/models/Share.js
api/server/routes/share.js
[1] [2] [3]🔧 Schema and Client Updates:
isVisible
andisAnonymous
fromshareSchema
inapi/models/schema/shareSchema.js
ShareButton
withuseGetSharedLinkQuery
for retrieving shared link data and added QR code generation inclient/src/components/Conversations/ConvoOptions/ShareButton.tsx
🐛 Bug Fixes & Improvements (Closes [Bug]: Incorrect Title when Sharing the Chat & Managing The Shared Links #5282):
generateLink
is clickedDataTable
component for handling infinite items (tested with 100,000 elements with no lag)🔄 Known Issues:
🔍 Ongoing adjustments required for search inDataTable
DataTable
cache logicChange Type
Testing
Tested main features (Share, Convo, Messages) with:
Test Configuration:
Checklist