-
-
Notifications
You must be signed in to change notification settings - Fork 187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stylix Kvantum is breaking plasma6 #835
Comments
Oh and if you wanna take a look and poke around, when the error message eventually comes up, you can click on the "how to submit a bug report" or whatever link, which will open up Kate that will have a terminal tab on the bottom you can use to poke around. |
This seems like a DE detection issue to me? Surely |
Setting |
How does it break System Settings? That seems like a separate issue. |
I didn't take a screenshot but it looks like it's missing all the styling elemenents and only colors remain, for example a checkbox is just a colored circle. For some reason it also causes some pages to be completely missing (like About this system and many others). I only removed stylix from my config and this fixed it. This is what I used before: { pkgs, ... }:
{
stylix = {
enable = true;
image = ./wallpaper.jpg;
base16Scheme = "${pkgs.base16-schemes}/share/themes/gruvbox-dark-hard.yaml";
targets.qt.platform = "kde";
fonts = {
monospace = {
package = pkgs.nerd-fonts.fantasque-sans-mono;
name = "FantasqueSansM Nerd Font";
};
serif = {
package = pkgs.source-serif;
name = "Source Serif";
};
sansSerif = {
package = pkgs.ibm-plex;
name = "IBM Plex Sans";
};
};
};
} |
In Home Manager, setting it causes System Settings from Plasma 5 amd all the There's a sort of solution linked in the issue as well, but in reality that bug probably needs to be fixed there. I did notice with the theme set this way, there were a few applications with incorrect theming (I don't quite remember 100% since I'm away from my computer but I think |
Having the same issue on my end. No idea how long you guys waited, but I couldn't get past the loading screen on Plasma in upwards of 10 minutes. |
Yeah honestly it's lucky if you even get past it with anything starting up. I got lucky and something crashed and that gave me an out to fix it. |
Doing some bisecting leads to commit b7f50a5 being the problem. Updating the original post to suggest a fix by pinning to the commit before that. |
Cc: @Mikilio
Should we implement that workaround or disable the |
I don't know tbh. I assume that the home-manager will at some point have to add the packages for plasma6 to the platformTheme packages. (Similar to how qtct actually adds packages for both qt5 and qt6) But I always had the impression that things move slow for qt in home-manager. |
It might be good to hotfix this on our side until Home Manager properly resolves this. Waiting on Home Manager might not be a good idea...
If the previously linked workaround has the closest behaviour to the intended one, we could implement that one. If this is not the case or the workaround is unreliable in its own ways, we could just disable the Since this hotfix "only" affects KDE and we are ideally waiting for an upstream fix, feel free to choose the easiest working implementation. |
This is probably incorrect. It actually works completely fine on Plasma 5. The right one is prob |
Oh, I didn't notice you wrote plasma5 I was assuming plasma6 from the beginning. |
Just reposting the workaround here for better discoverability: qt = {
enable = true;
platformTheme.package = with pkgs.kdePackages; [
plasma-integration
# I don't remember why I put this is here, maybe it fixes the theme of the system setttings
systemsettings
];
style = {
package = pkgs.kdePackages.breeze;
name = "Breeze";
};
};
systemd.user.sessionVariables = { QT_QPA_PLATFORMTHEME = "kde"; }; |
This adds temporary warnings when plasma6 is enabled and will be replaced with actual handling of plasma6 when styling solutions are added upstream. Currently, this requires a manual work around that is only reasonable on home-manager and not on NixOS. Users will be deferred to find workarounds in the issue when they encounter this warning. Relates to #835 Co-authored-by: NAHO <[email protected]>
This should be resolved by commit d171b19. |
That...does not actually seem like it fixes the problem, it just adds warnings, right? I mean it still doesn't work with plasma6 at all. |
Correct. |
Then what exactly is the utility of closing it? It's not resolved at all, and it's not a minor issue. |
It's also decidedly a breaking change--as in, computer boots, then does not. |
Uh, I'm getting errors now with my flake while trying to rebuild:
Stylix declaration:
|
I'm working on a home-manager PR (nix-community/home-manager#6493) that fully addresses this issue |
This adds temporary warnings when plasma6 is enabled and will be replaced with actual handling of plasma6 when styling solutions are added upstream. Currently, this requires a manual work around that is only reasonable on home-manager and not on NixOS. Users will be deferred to find workarounds in the issue when they encounter this warning. Relates to danth#835 Co-authored-by: NAHO <[email protected]>
This adds temporary warnings when plasma6 is enabled and will be replaced with actual handling of plasma6 when styling solutions are added upstream. Currently, this requires a manual work around that is only reasonable on home-manager and not on NixOS. Users will be deferred to find workarounds in the issue when they encounter this warning. Relates to danth#835 Co-authored-by: NAHO <[email protected]>
This adds temporary warnings when plasma6 is enabled and will be replaced with actual handling of plasma6 when styling solutions are added upstream. Currently, this requires a manual work around that is only reasonable on home-manager and not on NixOS. Users will be deferred to find workarounds in the issue when they encounter this warning. Relates to danth#835 Co-authored-by: NAHO <[email protected]>
Reopened until this is fully fixed |
Something like this should have been caught in tests. There should be a test for plasma6 since people are actually using it now. Regarding closing issues, I am also in favor of keeping issues that are basically waiting on upstream to be kept open. A lot of people don't actually modify the filters and just look at open issues. So this is better for discoverability. |
Yes, adding loads of testbeds is part of the roadmap:
Yes, my bad. |
Add a default value for the qt.platform option, following commit d171b19 ("qt: add temporary warnings for plasma6 (#845)") in an effort to resolve [1] ("Stylix Kvantum is breaking plasma6"). [1]: #835 Link: #884 Reviewed-by: NAHO <[email protected]>
Hi, Thanks you danth and all collaborators for this project. Just some newbie feedback.
I don't have the crash as before anymore when login into plasma if the qt.platform is set to "kde" instead of "qtct", but it still breaks/changes the Plasma Configuration Settings by removing many of the menus. For instance System Info is unavailable and Display Configuration is also reduced (for instance, no resolution, scaling, hdr, etc...). I don't use plasma6 often but only notice the changes on the Configuration. If the qt.platform is set to the default "qtct" crashes will happen. I will try removing fully any home-manager targets by setting the integration to false. |
Yeah, unfortunately. I can't really make any promises when it comes to plasma6, because I do not want this project to maintain workarounds unless upstreams confirms that it will not fix an issue. I am willing to make changes that improve UX navigating around these issues, I suppose there is a good argument for disabling the entire qt module when using plasma6. But you need to keep in mind that plasma6 on NixOS still has issues that have absolutely nothing to do with stylix, but as a downstream project it still receives the issues for it. On that note, I can only recommend to anyone using NixOS or home-manager to still wait a bit on plasma6. I appreciate all your help to test when I can adapt stylix to changes upstream that are in progress. |
I think the main issue here is that this is a regression in Stylix, period. On one commit Plasma 6 runs just fine (even if the theming is not perfect), then you update your lock file and your system no longer boots to a desktop without user-supplied workarounds. Many users (including me) found out about this because our systems suddenly became functionally unbootable. That's a major issue. Plasma 5 has had two minor point releases in the past year, there are people who can't simply go back to it without losing features that rely on. Adding Plasma 5 specific functionality that breaks Plasma 6 at this point seems like a misstep, even if it does bring improvements for Plasma 5 users. |
Thank you. I am not a plasma6 user most of the times, so for me this is not by any means a big hurdle, but the perks of functioning hdr on it lead me to test it sometimes. Just wanted to note and give feedback, even if unfortunate due to upstream. |
It's also a regression with Home-Manager and NixOS, since the |
I've been dealing with this bug for a long couple of days. The quick and dirty solution is pinning to commit b00c9f4 using
inputs.stylix.url = "github:danth/stylix?ref=b00c9f46ae6c27074d24d2db390f0ac5ebcc329f"
Plasma 6, by default, uses kvantum for its theming. Unfortunately when using kvantum with it now (I'm not really sure what changed to cause this), it breaks plasma6 completely. Its applications still run, but the desktop itself breaks.
I think the solution here is to move from kvantum (at least temporarily).
If you wanna test for yourself:
flake.nix to use as a testbed
You can run something like:
$ nix run .#nixosConfigurations.test.config.system.build.vm -- -smp 4 -m 4G
This bug from home-manager may be of interest to you as well: nix-community/home-manager#5098
The text was updated successfully, but these errors were encountered: