The VSCode theme is no longer only applied to any profiles by default.

I actually was meaning to have the default profile in the default list (like how I believe Firefox is?), but clearly I forgot to add that

Don't merge quite yet, please

edit: firefox does not actually theme any by default. in that case, i will follow that precedent

The VSCode theme is no longer only applied to any profiles by default.

edit: firefox does not actually theme any by default. in that case, i will follow that precedent

AFAIK, there are plans to apply the Firefox theme by default. However, due to some problems this has not been done yet. Should we add the default profile in this PR?

AFAIK, there are plans to apply the Firefox theme by default. However, due to some problems this has not been done yet. Should we add the default profile in this PR?

what exactly are the problems? if we were to add the default profile in this PR, i'd want to open one for firefox as well

AFAIK, there are plans to apply the Firefox theme by default. However, due to some problems this has not been done yet. Should we add the default profile in this PR?

what exactly are the problems? if we were to add the default profile in this PR, i'd want to open one for firefox as well

The relevant discussion is at #702.

The relevant discussion is at #702.

alright, so it seems like we're down to a judgement call between theming "default" by default or warning when the program is enabled but no profile is set for theming.

the former is the simplest and would result in the simplest behavior, but it is more likely that users are unaware that theming is not being applied

the latter has more complicated behavior but would ensure that the user knows when stylix theming is not being applied.

i prefer the latter behavior, as all the user has to do to disable the warning is to disable the module theming (or not enable the program)

The relevant discussion is at #702.

alright, so it seems like we're down to a judgement call between theming "default" by default or warning when the program is enabled but no profile is set for theming.

the former is the simplest and would result in the simplest behavior, but it is more likely that users are unaware that theming is not being applied

the latter has more complicated behavior but would ensure that the user knows when stylix theming is not being applied.

i prefer the latter behavior, as all the user has to do to disable the warning is to disable the module theming (or not enable the program)

Enabling a Stylix profile by default would align with Stylix's philosophy of "it just works".

Enabling a Stylix profile by default would align with Stylix's philosophy of "it just works".

the issue is that will only "just work" if they happen to use the Stylix profile

if we really wanted it to just work, we could try to poll config.programs.vscode.profiles for all set profiles (if that is even possible) and default to theming all set profiles. i suspect we would have some infinite recursion problems with this, though.

Enabling a Stylix profile by default would align with Stylix's philosophy of "it just works".

the issue is that will only "just work" if they happen to use the Stylix profile

if we really wanted it to just work, we could try to poll config.programs.vscode.profiles for all set profiles (if that is even possible) and default to theming all set profiles. i suspect we would have some infinite recursion problems with this, though.

I do not know how VSCode profiles work. Is it not possible to enable our Stylix profile without breaking other profiles?

if we really wanted it to just work, we could try to poll config.programs.vscode.profiles for all set profiles (if that is even possible) and default to theming all set profiles. i suspect we would have some infinite recursion problems with this, though.

i attempted the naive solution and ended with infinite recursion, as expected. i can't think of any way to get around the infinite recursion but am willing to pursue it with some help.

for now, i implemented a warning with the proposed behavior. i think that this would be good behavior for both vscode and firefox.

Is it not possible to enable our Stylix profile without breaking other profiles?

i believe that enabling our Stylix profile would work but no other would be themed and thus most people would not notice that it was available.