Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kafka component data race on subscribeTopics #3558

Open
famarting opened this issue Sep 30, 2024 · 2 comments
Open

kafka component data race on subscribeTopics #3558

famarting opened this issue Sep 30, 2024 · 2 comments
Labels
kind/bug Something isn't working

Comments

@famarting
Copy link
Contributor

Expected Behavior

the variable subscribeTopics here https://github.com/dapr/components-contrib/blob/main/common/component/kafka/kafka.go#L50C2-L50C17 can be concurrently accessed and in some scenarios is not protected against data races

Here https://github.com/dapr/components-contrib/blob/main/common/component/kafka/consumer.go#L247 and here https://github.com/dapr/components-contrib/blob/main/common/component/kafka/consumer.go#L236

the subscribeLock https://github.com/dapr/components-contrib/blob/main/common/component/kafka/kafka.go#L51 should be used to protect the concurrent usage of the subscribeTopics map

Actual Behavior

Steps to Reproduce the Problem

Release Note

RELEASE NOTE:

@famarting famarting added the kind/bug Something isn't working label Sep 30, 2024
Copy link

This issue has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in the next 7 days unless it is tagged (pinned, good first issue, help wanted or triaged/resolved) or other activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale label Oct 30, 2024
Copy link

github-actions bot commented Nov 6, 2024

This issue has been automatically closed because it has not had activity in the last 37 days. If this issue is still valid, please ping a maintainer and ask them to label it as pinned, good first issue, help wanted or triaged/resolved. Thank you for your contributions.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Nov 6, 2024
@olitomlinson olitomlinson reopened this Nov 16, 2024
@github-actions github-actions bot removed the stale label Nov 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants