Compatibility with Terkin: Timestamps are not accepted

[amotl]

Hi there,

friends of Kotori and Terkin just told us that a timestamp field they added with a patch like hiveeyes/terkin-datalogger#111, would not be accepted by Kotori.

The corresponding slot of the JSON payload looks like:

"timestamp": 1637431069.6585083

With kind regards,
Andreas.

[amotl]

Thoughts

After looking at the code, ac6975f quickly reveals that the routine for parsing the Unix/Epoch time format might only be looking at values of type int.

kotori/kotori/daq/storage/influx.py

Lines 211 to 218 in 0247da5

	# Heuristically compute timestamp precision
	if isinstance(timestamp, int):
	if timestamp >= 1e17 or timestamp <= -1e17:
	time_precision = 'n'
	elif timestamp >= 1e14 or timestamp <= -1e14:
	time_precision = 'u'
	elif timestamp >= 1e11 or timestamp <= -1e11:
	time_precision = 'ms'

On the other hand, numeric timestamp values seem to be converted to int values beforehand, so everything should be fine.

kotori/kotori/daq/storage/influx.py

Lines 177 to 180 in 0247da5

	# Decode timestamp.
	chunk['time'] = data[time_field]
	if is_number(chunk['time']):
	chunk['time'] = int(float(chunk['time']))

We will have to investigate this further on behalf of a software test.

[amotl]

Hi again,

#79 shows that Kotori already accepts fractional epoch timestamps. However, the patch improves this topic a bit more.

With kind regards,
Andreas.