Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reference DBs, UserTypes, and UserFunctions in ASTs by ID rather than Name #3964

Closed
pbiggar opened this issue May 25, 2022 · 1 comment
Closed

Reference DBs, UserTypes, and UserFunctions in ASTs by ID rather than Name #3964

pbiggar opened this issue May 25, 2022 · 1 comment

Comments

@pbiggar
Copy link
Member

pbiggar commented May 25, 2022 •
edited
Loading

Functions, DBs and types are all referenced in the AST by name. Instead, we should refer to them by TLID. This means they won't go out of sync, they're faster to look up, and they're less likely or impossible to accidentally refer to a non-existing one. This will also mean that renaming them won't require changes to other toplevels (a key way these go out of sync)
@pbiggar pbiggar changed the title Use IDs for variables, DBs, UserTypes, and UserFunctions Use IDs for DBs, UserTypes, and UserFunctions May 25, 2022
@pbiggar pbiggar moved this to Ready to go in Darklang priorities May 28, 2022
@StachuDotNet StachuDotNet changed the title Use IDs for DBs, UserTypes, and UserFunctions Reference DBs, UserTypes, and UserFunctions by ID rather than Name Jun 22, 2022
@StachuDotNet StachuDotNet changed the title Reference DBs, UserTypes, and UserFunctions by ID rather than Name Reference DBs, UserTypes, and UserFunctions in ASTs by ID rather than Name Jun 22, 2022
@pbiggar pbiggar added this to the Good experience for solo dev milestone Oct 18, 2022
@StachuDotNet StachuDotNet mentioned this issue Jan 14, 2024
Open
13 tasks
@StachuDotNet
Copy link
Member

folded into #5259

@github-project-automation github-project-automation bot moved this from Ready to go to Done in Release 3 in Darklang priorities Jan 14, 2024
@StachuDotNet StachuDotNet mentioned this issue Jan 14, 2024
Open
47 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
Darklang priorities
Status: Done in Release 3
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pbiggar @StachuDotNet