Finding a way to upstream a stream of changes from my fork

[jbhoot]

I have made several modifications to this repo in my (new) fork, like

• fix onCheck event handler (jbhoot@1c5beaf)
• fix how role attribute is created: as an attribute instead of as a property (jbhoot@c8c238c)
• fix how boolean attributes are created (jbhoot@33890ed)
• add onLinkClick handler (which also handle preventDefault()) (jbhoot@79c1c4f)
• add new attributes

Initially I thought of creating a branch and an associated pull request for each change. However, I need to use these changes immediately in my code. So I need all of those changes within a single branch.

Now I am committing everything to the main branch of my fork. Each commit still deals with only one thing. Each commit message also describes the why, if needed.

This way, we can merge these changes in this repo at leisure.

Let me know if and how you would like to handle this.

[pbiggar]

What I've been doing is upstreaming individually, and then waiting until they're all in toe switch over. Another option would be rebasing the fork as they get merged.

Would this work for you?

onCheck, role, boolean attrs, and new attrs seem great. I'm not sure what onLinkCheck does so I'm not sure yet.

[jbhoot]

What I've been doing is upstreaming individually, and then waiting until they're all in toe switch over. Another option would be rebasing the fork as they get merged.

Creating a PR per change won't work at the moment. I need to progress in my work at a prolific pace. Hence I need to keep an up-to-date repo with all the fixes for the bugs I encounter in rescript-tea.

But I cannot expect you to accept every PR I make, and that too immediately.

So rebasing the fork, or may be cherry-picking commits, should work.

[jbhoot]

On the other hand, feel free to pick anything from my fork without waiting for me to create PRs.

[jbhoot]

I'm not sure what onLinkCheck does so I'm not sure yet.

Would

a(list{href("#"), onClick(v => LinkClicked(v))}, list{"Click me"->text})

trigger e.preventDefault() automatically?

As far as I can recall, it doesn't, causing the page to reload to the href.

a(list{href("#"), onLinkClick(v => LinkClicked(v))}, list{"Click me"->text})

would trigger preventDefault(), and issue the msg. Internally, onLinkClick uses preventDefaultOn.

So it essentially a utility function.

[pbiggar]

I see, that makes sense. Maybe it would be a good idea to include an @ocaml.doc( documentation string that explain this.

[pbiggar]

So rebasing the fork, or may be cherry-picking commits, should work.

Great yeah. If you make PRs for anything that's ready and rebase off them, we should be able to get these done quickly! Thanks again!