Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

consider consolidating health check builds #307

Open
devoncarew opened this issue Oct 15, 2024 · 4 comments
Open

consider consolidating health check builds #307

devoncarew opened this issue Oct 15, 2024 · 4 comments

Comments

@devoncarew
Copy link
Member

The health check workflow runs several (~6) builds per PR; we may want to consider consolidating the checks into one build, just for a simpler presentation in the PR UI. Here's the existing PR checks UI:

Screenshot 2024-10-15 at 10 29 57 AM

cc @mosuem

@mosuem
Copy link
Member

mosuem commented Oct 16, 2024

We split them up a while ago, to make it easier to understand which one failed. I am fine with switching back though.

@devoncarew
Copy link
Member Author

Perhaps we could run them as separate steps in a build? Or have some other way to group the output to help call out which steps failed.

@mosuem
Copy link
Member

mosuem commented Oct 17, 2024

I normally only look at the steps which failed, which is why am fine with the current solution. I don't think there is a way to group actions, that would be ideal..

What do you mean with run them as separate steps in a build?

@devoncarew
Copy link
Member Author

Something like:

Screenshot 2024-10-17 at 9 13 56 AM

I'd have to look at how the health.yml file is set up - it might surface as having individual steps in a steps: section? It would probably mean a bit of an architectural change to the file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants