From 5c36bb2423b04a2e6cc6554bd8aa92ffcd7f1f0b Mon Sep 17 00:00:00 2001 From: Konstantin Akimov Date: Tue, 24 Dec 2024 19:48:37 +0700 Subject: [PATCH] docs: add TODO about bls global variable --- src/validation.cpp | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/validation.cpp b/src/validation.cpp index 3cd5345de0..be7078aaf8 100644 --- a/src/validation.cpp +++ b/src/validation.cpp @@ -4042,6 +4042,9 @@ bool TestBlockValidity(BlockValidationState& state, AssertLockHeld(cs_main); assert(pindexPrev && pindexPrev == chainstate.m_chain.Tip()); + // TODO: instead restoring bls_legacy_scheme better to keep it unchanged + // Moreover, current implementation is working incorrent if current function + // will return value too early due to error: old value won't be restored auto bls_legacy_scheme = bls::bls_legacy_scheme.load(); uint256 hash = block.GetHash();