Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deploy tool can fail to unban masternodes if collateral address contains no fee UTXOs #304

Open
strophy opened this issue Jun 27, 2022 · 0 comments
Labels

Comments

@strophy
Copy link
Collaborator

strophy commented Jun 27, 2022

Expected Behavior

Deploy tool should unban all banned masternodes without any issues

Current Behavior

The collateral address is also used as the fee source address when creating ProUpServTx in the mn-init role. In rare cases, the fee UTXO may have been spent and moved to a change address due to previous unban operations or operations on the testnet wallet on other clients.

Possible Solution

Deploy tool should check there is balance to pay for fees and create it if necessary before attempting to unban nodes. Alternatively, we could use a single fee source address, which would probably speed up mn-init because only one fee funding transaction would be necessary, rather than as many transactions as there are masternodes.

Steps to Reproduce (for bugs)

Context

Your Environment

  • Version used:
  • Environment name and version (e.g. Chrome 39, node.js 5.4):
  • Operating System and version (desktop, server, or mobile):
  • Link to your project:
@strophy strophy added the bug label Jun 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant