Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure that authorization requests only request a dataset once #171

Open
erlendoksvoll opened this issue Feb 13, 2025 · 0 comments
Open
Assignees
Labels
enhancement New feature or request

Comments

@erlendoksvoll
Copy link
Member

erlendoksvoll commented Feb 13, 2025

Description

If the same data set is requested multiple times it will generate a server error from AuthorizationRequestValidatorService
var requirements = _evidenceCodesFromRequest.ToDictionary(es => es.EvidenceCodeName, es => es.AuthorizationRequirements);

Doing this should generate a validation error with a descriptive error message

Note: The error we saw was due to two datasets being registered in a plugin with the same name which caused a myriad of problems, but that is harder to avoid in design-time

Additional Information

No response

Tasks

No response

@erlendoksvoll erlendoksvoll added the enhancement New feature or request label Feb 13, 2025
@erlendoksvoll erlendoksvoll moved this to 🔖 Ready in DAN public backlog Feb 13, 2025
@SondreJDigdir SondreJDigdir moved this from 🔖 Ready to 🏗 In progress in DAN public backlog Feb 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: 🏗 In progress
Development

No branches or pull requests

2 participants